Skip to content

Remove preview LangVersion from empty project template #33830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove preview LangVersion from empty project template #33830

wants to merge 1 commit into from

Conversation

halter73
Copy link
Member

Addresses #33813

@halter73 halter73 requested a review from Pilchie as a code owner June 24, 2021 23:34
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jun 24, 2021
davidfowl
davidfowl approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we don't have the SDK yet.

@halter73
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@pranavkm
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@DamianEdwards
Copy link
Member

This doesn't need to be merged anymore, it was already removed.

@davidfowl davidfowl closed this Jul 19, 2021
@dougbu dougbu deleted the halter73/33813 branch August 21, 2021 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@DamianEdwards DamianEdwards DamianEdwards approved these changes

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@halter73 @pranavkm @DamianEdwards @davidfowl