Use top level program for the Worker template #33853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
|
Timing seemed appropriate with other discussions going on. I'd love to see the Worker as a top-level. I like this. |
|
I'd like to see the template further simplified with global usings (like in the websdk). |
davidfowl
reviewed
Jun 27, 2021
src/ProjectTemplates/Web.ProjectTemplates/content/Worker-CSharp/Program.cs
Outdated
Show resolved
Hide resolved
|
I think we want to do this for all of the templates as well. |
…p/Program.cs Co-authored-by: David Fowler <[email protected]>
|
FYI @DamianEdwards since he's updating templates right now. I'm okay merging this as is and letting Damian make any additional changes in his PR |
|
Yep we're in the process of updating all the templates now, see #33947 |
5 tasks
bradygaster
approved these changes
Jul 1, 2021
Merged
pranavkm
pushed a commit
that referenced
this pull request
Jan 21, 2022
I think most of the other top-level programs/templates call `Run()` instead of `await RunAsync()`. For the sake of consistency we should probably use `Run`. Related to the evolution of templates with .NET 6: - #33853
ShreyasJejurkar
pushed a commit
to ShreyasJejurkar/aspnetcore
that referenced
this pull request
Jan 22, 2022
I think most of the other top-level programs/templates call `Run()` instead of `await RunAsync()`. For the sake of consistency we should probably use `Run`. Related to the evolution of templates with .NET 6: - dotnet#33853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the Worker template by half, using top level statements.
/cc @bradygaster and @shirhatti