Honor RecursiveDir when used on packed items in framework packs

[ericstj]

When packaging Analyzers in the ref-pack we were setting PackagePath to the full path inside the package (by appending %(RecursiveDir)) then Nuget was appending %(RecursiveDir) again during pack. Avoid this by removing the expansion in our own items and fixing the CreateFrameworkList task to append %(RecurisveDir) in a similar manner to NuGet.

Addresses #34272

[captainsafia]

Thanks for digging into this. Let's try undoing the workarounds made in the dependency update PR to see if this works. I can undo the changes made in that PR if you add me as a collaborate to your fork, @ericstj.

[ericstj]

I've added you, @captainsafia

[captainsafia]

Looks like there is still a failure related to the logging generator:

CSC(0,0): error CS0006: (NETCORE_ENGINEERING_TELEMETRY=Build) Metadata file 'D:\workspace\_work\1\s\.dotnet\packs\Microsoft.AspNetCore.App.Ref\6.0.0-ci\analyzers/dotnet/cs/Microsoft.Extensions.Logging.Generators.dll' could not be found

The error occurs when building the InteropWebsite project on Helix.

[ericstj]

It looks like it's running from packs copied to the repo local .dotnet/packs folder. I suspect there is part of AspNet infra that's copying things to that location. It must be copying the framework list but not the rest of the ref pack.

[ericstj]

I see, these are additional targets in the ref-pack project.

aspnetcore/src/Framework/App.Ref/src/Microsoft.AspNetCore.App.Ref.csproj

Lines 204 to 227 in 69eb4b3

	<Target Name="_BatchCopyToLayoutTargetDir"
	DependsOnTargets="_ResolveTargetingPackContent"
	Inputs="@(RefPackContent)"
	Outputs="@(RefPackContent->'$(LayoutTargetDir)%(PackagePath)%(FileName)%(Extension)')">
	<Copy SourceFiles="@(RefPackContent)"
	DestinationFiles="@(RefPackContent->'$(LayoutTargetDir)%(PackagePath)%(FileName)%(Extension)')"
	UseHardlinksIfPossible="true" />
	<Message Importance="High" Text="$(MSBuildProjectName) -> $(LayoutTargetDir)" />
	</Target>
	<ItemGroup>
	<CreateDirectory Include="$(LocalInstallationOutputPath)" />
	</ItemGroup>
	<!-- Workaround https://github.com/dotnet/sdk/issues/2910 by copying targeting pack into local installation. -->
	<Target Name="_InstallTargetingPackIntoLocalDotNet"
	DependsOnTargets="_ResolveTargetingPackContent"
	Inputs="@(RefPackContent)"
	Outputs="@(RefPackContent->'$(LocalInstallationOutputPath)%(PackagePath)%(FileName)%(Extension)')">
	<Copy SourceFiles="@(RefPackContent)"
	DestinationFiles="@(RefPackContent->'$(LocalInstallationOutputPath)%(PackagePath)%(FileName)%(Extension)')"
	UseHardlinksIfPossible="true" />
	<Message Importance="High" Text="$(MSBuildProjectName) -> $(LocalInstallationOutputPath)" />
	</Target>

[dougbu]

nit:

Suggested change

	private static string GetPackagePath(ITaskItem item)
	private static string GetPackagePath(ITaskItem item)

[captainsafia]

Merging to unblock SDK insertion.