HTTP/3: Http3Stream pooling #34576
Merged
HTTP/3: Http3Stream pooling #34576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
halter73,
Pilchie and
Tratcher
as code owners
Tratcher
approved these changes
Jul 21, 2021
JamesNK
force-pushed
the
jamesnk/http3-http3streapooling3
branch
from
4a31edd to
899e200
Compare
halter73
reviewed
Jul 22, 2021
| _streamLifetimeHandler.OnStreamCreated(stream); | ||
|
|
||
| ThreadPool.UnsafeQueueUserWorkItem(stream, preferLocal: false); | ||
| } | ||
| else | ||
| { | ||
| var persistentStateFeature = streamContext.Features.Get<IPersistentStateFeature>(); | ||
| Debug.Assert(persistentStateFeature != null, $"Required {nameof(IPersistentStateFeature)} not on stream context."); |
There was a problem hiding this comment.
This seems too possible to just assert given the transport is pluggable. Let's null-check and throw.
halter73
approved these changes
Jul 22, 2021
JamesNK
force-pushed
the
jamesnk/http3-http3streapooling3
branch
from
899e200 to
858d3ee
Compare
dougbu
suggested changes
Jul 23, 2021
|
I thought I had already updated old files. Which ones still need to be updated? |
dougbu
approved these changes
Jul 23, 2021
|
Before - 300mb allocated for 10,000 requests After - 50mb allocated for 10,000 requests |
ghost
added this to the 
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33680
This builds on top of the new
IPersistentStateFeature.Http3Stream and many of its associated types (pipes, output producer, decoder) are now reused between requests.
In this PR I also added some basic microbenchmarks that do HTTP/3. Refactoring the test code so it is usable in microbenchmarks is the major of line changes in this PR.
I will get benchmarks comparing allocations before and after.