HTTP/3: Raise RequestAbort on client cancellation #34675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
ghost
added
the
JamesNK
changed the title
JamesNK
commented
Jul 24, 2021
|
|
||
| var serverWriteTask = await readAsyncTask.Task.DefaultTimeout(); | ||
|
|
||
| var ex = await Assert.ThrowsAnyAsync<OperationCanceledException>(() => serverWriteTask).DefaultTimeout(); |
There was a problem hiding this comment.
If the request is aborted and ReadAsync or WriteAsync are called on the server, what should the exception type be? I think HTTP/2 throws IOException...
JamesNK
force-pushed
the
jamesnk/http3-clientabort
branch
from
3482a8e to
4f6b17e
Compare
halter73
reviewed
Jul 26, 2021
| { | ||
| // TODO: This is temporary. Don't want to tie HTTP/3 layer to one transport. | ||
| // This is here to check what other exceptions can cause ConnectionResetException. | ||
| Debug.Assert(ex.InnerException is QuicStreamAbortedException); |
There was a problem hiding this comment.
This really only affects local development, right? I'm not sure this is worth checking in especially if we're not confident in it. Maybe just keep it as a stash you reapply locally? I guess it's not a big deal either way.
There was a problem hiding this comment.
Yes.
I want to check because I'm not confident and I want it to break locally
halter73
approved these changes
Jul 26, 2021
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34674