Skip to content

Update samples to beta3 #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2015
Merged

Update samples to beta3 #348

merged 1 commit into from
Mar 12, 2015

Conversation

friism
Copy link
Contributor

@friism friism commented Mar 2, 2015

I've finally gotten the CLA signed

@ghost
Copy link

ghost commented Mar 2, 2015

Hi @friism, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.

TTYL, MSOTBOT;

@ghost ghost added the cla-required label Mar 2, 2015
@friism
Copy link
Contributor Author

friism commented Mar 2, 2015

@msotclas I've gotten the CLA signed already.

@friism friism mentioned this pull request Mar 2, 2015
Merged
@ahmetb
Copy link

ahmetb commented Mar 2, 2015

@friism can you please squash commits into one commit?

@Eilon @suhasj can we review this, blocks docker image release for beta3.

@friism friism force-pushed the update-samples-to-beta3 branch from d384129 to fe97523 Compare March 2, 2015 19:20
@friism
Copy link
Contributor Author

friism commented Mar 2, 2015

@ahmetalpbalkan commits squashed

Eilon
Eilon reviewed Mar 3, 2015
View reviewed changes
samples/ConsoleApp/project.json
@@ -7,7 +7,7 @@
"aspnetcore50": {
"dependencies": {
"System.Console": "4.0.0-beta-*"
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabs 😦 🐼

@Eilon
Copy link
Contributor

Eilon commented Mar 3, 2015

@anurse can you evaluate? I vaguely recall you mentioning in another PR about how we want to flow changes for samples (i.e. through dev or not).

@friism friism force-pushed the update-samples-to-beta3 branch from fe97523 to b1b5cbb Compare March 3, 2015 03:07
@friism
Copy link
Contributor Author

friism commented Mar 3, 2015

@Eilon tabs removed

@friism
Copy link
Contributor Author

friism commented Mar 3, 2015

@Eilon @anurse I'm unsure if flowing changes through dev branch makes sense for this, since it's not a new feature but a bug-fix.

@davidfowl davidfowl mentioned this pull request Mar 4, 2015
Closed
@Eilon
Copy link
Contributor

Eilon commented Mar 9, 2015

@anurse can you take a look on Monday?

@Eilon Eilon self-assigned this Mar 9, 2015
@Eilon
Copy link
Contributor

Eilon commented Mar 9, 2015

Marking as CLA-ok... I manually checked the database.

@Eilon Eilon assigned analogrelay and unassigned Eilon Mar 9, 2015
@muratg
Copy link
Contributor

muratg commented Mar 9, 2015

Looks good to me. I'll let @anurse put the ship it label and handle the PR.

@ahmetb
Copy link

ahmetb commented Mar 12, 2015

@muratg @anurse @Eilon ping. this is blocking Docker image release. aspnet/aspnet-docker#38

Praburaj
Praburaj reviewed Mar 12, 2015
View reviewed changes
samples/ConsoleApp/project.json
}
}
"dependencies": {
"System.Console": "4.0.0-beta-*"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package version can also be fixed. Version will be 4.0.0-beta-22605

Praburaj pushed a commit that referenced this pull request Mar 12, 2015
Merge pull request #348 from friism/update-samples-to-beta3
edb8b06 
Update samples to beta3
@Praburaj Praburaj merged commit edb8b06 into dotnet:master Mar 12, 2015
@ahmetb ahmetb mentioned this pull request Mar 23, 2015
Closed
jkotalik pushed a commit that referenced this pull request Nov 1, 2018
@Tratcher
#348 Implement IISHostingStartup
d632287
ryanbrandenburg pushed a commit that referenced this pull request Nov 16, 2018
@kichalla
Added makefile.shade to run nano tests
2fb9e2f 
[Fixes #348] Only run Nano tests for the WinNano-MusicStore node in CI
ryanbrandenburg pushed a commit that referenced this pull request Nov 19, 2018
@HaoK
Split sqllite and sql server migrations (#348)
7db6925 
* Split sqllite and sql server migrations

* Fix casing, move files around

* Remove if defs and add check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@analogrelay analogrelay

Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@friism @ahmetb @Eilon @muratg @Praburaj @analogrelay