Update fedora queue for skipping #35122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
HaoK
approved these changes
Aug 6, 2021
dougbu
reviewed
Aug 6, 2021
| @@ -11,7 +11,7 @@ | |||
| <PropertyGroup Condition="'$(TestDependsOnPlaywright)' == 'true'"> | |||
| <SkipHelixQueues> | |||
| (Alpine.312.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.12-helix-20200908125345-56c6673; | |||
| (Fedora.33.Amd64.Open)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-33-helix-20210120000908-a9df267; | |||
| (Fedora.34.Amd64.Open)ubuntu.1604.amd64.open@mcr.microsoft.com/dotnet-buildtools/prereqs:fedora-34-helix-20210728124700-4f64125; | |||
There was a problem hiding this comment.
Why are we using EOL Ubuntu 16.04 as a base for anything❔ That OS hasn't been supported since April.
There was a problem hiding this comment.
It's the only queue that supports msquic, @wfurt set it up - why use ubuntu16 instead of 18?
|
The base line OS does not matter @wtgodbe. Runtime uses ubuntu16 and I did not want to change that. It should work with Ubuntu18 or 20 as long as you give it the |
|
Hi @wfurt. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.