Add a new shadowcopy test #35249
Merged
Add a new shadowcopy test #35249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
BrennanConroy
approved these changes
Aug 11, 2021
| DirectoryCopy(deploymentResult.ContentRoot, secondTempDir.DirectoryPath, copySubDirs: true); | ||
| DirectoryCopy(secondTempDir.DirectoryPath, deploymentResult.ContentRoot, copySubDirs: true); | ||
|
|
||
| response = await deploymentResult.HttpClient.GetAsync("Wow!"); |
There was a problem hiding this comment.
Why even try a request here?
There was a problem hiding this comment.
Mostly wanted to see how graceful/what would happen, I was hoping it would consistently return Application Shutting Down like it does locally. I could remove it, but we get some coverage that we get a 503 or 200 at least here, so I felt it has some value
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New test that verifies what happens when the shadow copy directory has an existing '1' directory to verify incremental behavior