Skip to content

Mark public Quic API as preview #35307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2021
Merged

Mark public Quic API as preview #35307

merged 1 commit into from
Aug 12, 2021

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Aug 12, 2021

Replaces #35202

@pgovind @jeffhandley @jkotas do we need to mark the individual properties in QuicTransportOptions too, or does marking the whole class do the trick?

@ghost ghost added the area-runtime label Aug 12, 2021
@wtgodbe wtgodbe mentioned this pull request Aug 12, 2021
Closed
JamesNK
JamesNK approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wtgodbe wtgodbe merged commit 0286358 into main Aug 12, 2021
@wtgodbe wtgodbe deleted the wtgodbe/TimeoutPreview branch August 12, 2021 23:00
@ghost ghost added this to the 6.0-rc1 milestone Aug 12, 2021
@JamesNK
Copy link
Member

JamesNK commented Aug 12, 2021

@pgovind @jeffhandley @jkotas do we need to mark the individual properties in QuicTransportOptions too, or does marking the whole class do the trick?

TBH it probably doesn't matter one way or the other for this situation. The only methods it can be used with are marked as preview.

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@Tratcher Tratcher Tratcher approved these changes

@adityamandaleeka adityamandaleeka Awaiting requested review from adityamandaleeka

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

Assignees
No one assigned
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
6.0-rc1
Development

Successfully merging this pull request may close these issues.
4 participants
@wtgodbe @JamesNK @Tratcher @amcasey