-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/6.0-rc1] E2E test fixes #35460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/6.0-rc1] E2E test fixes #35460
Conversation
… removing Ignitor)
…ulTerminationTests.cs Co-authored-by: Tanay Parikh <[email protected]>
Ask mode template: DescriptionSee above Customer ImpactDoesn't affect customers, but helps us to have fewer build issues. Regression?
[If yes, specify the version the behavior has regressed from] Risk
[Justify the selection above] Verification
Packaging changes reviewed?
Addresses [issue number] N/a |
@davidfowl I heard you're in charge of approving this. It's test-only and helps us. |
Is it supposed to make the components pipeline pass? |
There's a massive difference between running locally and running in CI. Running locally, these changes gave me a near-100% pass rate over ~30 runs. There were 3 tests that still had intermittent issues, which I've addressed in #35505. Since then I've run the whole test suite locally another ~15 times and had a 100% pass rate. As for running in CI, it's a completely different story. I don't know why CI is unable to provide a consistent environment like running locally does. We need to work on this too, but the first step is to make sure the tests themselves are not having problems when run in a predictable (local) environment. |
Approved |
Backport of #35414 to release/6.0-rc1
/cc @SteveSandersonMS
Customer Impact
This is a test-only change and is needed to improve test stability and correctness.
Testing
This is testing.
Risk
None - no product impact