Skip to content

[release/6.0-rc1] E2E test fixes #35460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Aug 19, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 18, 2021

Backport of #35414 to release/6.0-rc1

/cc @SteveSandersonMS

Customer Impact

This is a test-only change and is needed to improve test stability and correctness.

Testing

This is testing.

Risk

None - no product impact

@github-actions github-actions bot requested review from Pilchie and a team as code owners August 18, 2021 16:45
@SteveSandersonMS
Copy link
Member

Ask mode template:

Description

See above

Customer Impact

Doesn't affect customers, but helps us to have fewer build issues.

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

Addresses [issue number]

N/a

@SteveSandersonMS
Copy link
Member

@davidfowl I heard you're in charge of approving this. It's test-only and helps us.

@BrennanConroy BrennanConroy added area-blazor Includes: Blazor, Razor Components tell-mode Indicates a PR which is being merged during tell-mode labels Aug 19, 2021
@davidfowl
Copy link
Member

Is it supposed to make the components pipeline pass?

@SteveSandersonMS
Copy link
Member

Is it supposed to make the components pipeline pass?

There's a massive difference between running locally and running in CI.

Running locally, these changes gave me a near-100% pass rate over ~30 runs. There were 3 tests that still had intermittent issues, which I've addressed in #35505. Since then I've run the whole test suite locally another ~15 times and had a 100% pass rate.

As for running in CI, it's a completely different story. I don't know why CI is unable to provide a consistent environment like running locally does. We need to work on this too, but the first step is to make sure the tests themselves are not having problems when run in a predictable (local) environment.

@davidfowl davidfowl added the Servicing-approved Shiproom has approved the issue label Aug 19, 2021
@davidfowl
Copy link
Member

Approved

@BrennanConroy BrennanConroy enabled auto-merge (squash) August 19, 2021 18:02
@BrennanConroy BrennanConroy merged commit 2becbdd into release/6.0-rc1 Aug 19, 2021
@BrennanConroy BrennanConroy deleted the backport/pr-35414-to-release/6.0-rc1 branch August 19, 2021 18:03
@ghost ghost added this to the 6.0-rc1 milestone Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components Servicing-approved Shiproom has approved the issue tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants