Skip to content

Upgrade Selenium Version #35949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2021
Merged

Upgrade Selenium Version #35949

merged 1 commit into from
Aug 31, 2021

Conversation

TanayParikh
Copy link
Contributor

Upgrading to latest stable selenium. The other two Selenium packages are already up to date.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 30, 2021
@TanayParikh TanayParikh marked this pull request as ready for review August 31, 2021 18:02
@TanayParikh TanayParikh requested a review from dougbu as a code owner August 31, 2021 18:02
@TanayParikh TanayParikh enabled auto-merge (squash) August 31, 2021 18:02
@TanayParikh TanayParikh requested a review from a team August 31, 2021 18:02
@TanayParikh TanayParikh disabled auto-merge August 31, 2021 18:03
dougbu
dougbu approved these changes Aug 31, 2021
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this works fine, please do the same in at least release/6.0.

Might be needed in our servicing branches too. But, let's wait until we hit problems there.

@TanayParikh TanayParikh mentioned this pull request Aug 31, 2021
Merged
@TanayParikh
Copy link
Contributor Author

Verified the Selenium E2E tests are working with the updated driver locally (as they're no longer run via the CI)

@TanayParikh TanayParikh merged commit 2a254d0 into main Aug 31, 2021
@TanayParikh TanayParikh deleted the taparik/upgradeSelenium branch August 31, 2021 20:44
@ghost ghost added this to the 7.0-preview1 milestone Aug 31, 2021
TanayParikh added a commit that referenced this pull request Sep 1, 2021
@TanayParikh
Revert "Upgrade Selenium Version (#35949)"
5a7c073 
This reverts commit 2a254d0.
This was referenced Sep 1, 2021
Merged
Closed
TanayParikh added a commit that referenced this pull request Sep 1, 2021
@TanayParikh
Revert "Upgrade Selenium Version (#35949)" (#36033)
7d4dd72 
This reverts commit 2a254d0.
@sebastienros
Copy link
Member

Verified the Selenium E2E tests are working with the updated driver locally (as they're no longer run via the CI)

Do you meant that a PR that would update these versions doesn't use the updated versions?
I can see the step in my PR:

#36107

image

@TanayParikh
Copy link
Contributor Author

I was referring to the src/Components/test/E2ETests specifically which use this selenium driver but are no longer run on the CI. This is different from the quarantined tests which as you noted are still on the CI.

@sebastienros
Copy link
Member

Should these quarantined tests use the new selenium version? It shows 91 instead of 93 still:

https://dev.azure.com/dnceng/_apis/resources/Containers/8072696/Windows_Quarantined_Test_Results?itemPath=Windows_Quarantined_Test_Results%2FRelease%2FQuarantined%2FMicrosoft.AspNetCore.Components.E2ETests_net6.0_x64.html

@TanayParikh
Copy link
Contributor Author

I believe those should be on 93 as well, don't see any reason why they would be intentionally a version behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@TanayParikh @sebastienros @dougbu