Skip to content

Create .rpm's for Linux Mariner #36094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Create .rpm's for Linux Mariner #36094

merged 1 commit into from
Sep 3, 2021

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Sep 2, 2021

Fixes #35725 (will need to be backported to 6.0)

We don't use the Arcade Installers package to generate these, so need to roll our own solution. I just copy the existing .rpm's with the new name (which is what Arcade does too: dotnet/arcade#7812).

Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1338101&view=results

@wtgodbe wtgodbe requested review from NikolaMilosavljevic, epananth and a team September 2, 2021 16:25
@wtgodbe wtgodbe requested a review from Pilchie as a code owner September 2, 2021 16:25
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 2, 2021
@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 2, 2021

Test job produced and published:

aspnetcore-runtime-7.0.0-alpha.1.21452.9-x64.rpm
aspnetcore-runtime-7.0.0-alpha.1.21452.9-cm.1-x64.rpm
aspnetcore-targeting-pack-7.0.0-alpha.1.21452.9.rpm
aspnetcore-targeting-pack-7.0.0-alpha.1.21452.9-cm.1.rpm

@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 2, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021

Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but, if I may ask, why not calculate $(CblMarinerTargetPath) in the Directory.Build.targets file❔ Property functions should make it easy to split out the parts and reassemble them w/ -cm1-x64 inserted.

@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 3, 2021

Property functions should make it easy to split out the parts and reassemble them w/ -cm1-x64 inserted.

True, but I think it's more readable to set them literally, plus it matches what we were already doing with TargetPath and TargetFileName

@wtgodbe wtgodbe merged commit 5ef6ea2 into main Sep 3, 2021
@wtgodbe wtgodbe deleted the wtgodbe/rpm branch September 3, 2021 16:10
@ghost ghost added this to the 7.0-preview1 milestone Sep 3, 2021
@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 23, 2021

/backport to release/5.0

@wtgodbe
Copy link
Member Author

wtgodbe commented Sep 23, 2021

/backport to release/3.1

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add & publish a cm.1 file for each .rpm we ship
4 participants