-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Create .rpm's for Linux Mariner #36094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test job produced and published:
|
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1195750434 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works but, if I may ask, why not calculate $(CblMarinerTargetPath)
in the Directory.Build.targets file❔ Property functions should make it easy to split out the parts and reassemble them w/ -cm1-x64
inserted.
True, but I think it's more readable to set them literally, plus it matches what we were already doing with |
/backport to release/5.0 |
/backport to release/3.1 |
Started backporting to release/5.0: https://github.com/dotnet/aspnetcore/actions/runs/1266977545 |
Started backporting to release/3.1: https://github.com/dotnet/aspnetcore/actions/runs/1266977708 |
Fixes #35725 (will need to be backported to 6.0)
We don't use the Arcade Installers package to generate these, so need to roll our own solution. I just copy the existing .rpm's with the new name (which is what Arcade does too: dotnet/arcade#7812).
Test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1338101&view=results