Update branding for 5.0.11

[vseanreesermsft]

No description provided.

[dougbu]

In addition to @BrennanConroy's mcr fix, something is messing up in the nginx installation. Assigning to @wtgodbe for fixes

[wtgodbe]

We might need #30253

[wtgodbe]

ContinueOnError for installing nginx looks like the way to go, tests still pass, and that leg doesn't produce anything we publish. Filed actions/runner-images#4049 for them to fix the image issue, but it isn't blocking at the moment.

[wtgodbe]

Think we need to update selenium

[wtgodbe]

That's not doing it:

D:\workspace_work\1\s\src\Components\test\E2ETest\Microsoft.AspNetCore.Components.E2ETests.csproj : error NU1604: Project dependency Selenium.Support does not contain an inclusive lower bound. Include a lower bound in the dependency version to ensure consistent restore results. [D:\workspace_work\1\s.dotnet\sdk\5.0.206\NuGet.targets]

@sebastienros @javiercn @SteveSandersonMS Components E2E tests are failing here, what did we do to fix them in main other than the Selenium update?

Edit: hold the phone on that, might have been due to my bad merge conflict resolution

[sebastienros]

This PR is missing the selenium.config file change. @HaoK did you submit a backport of my PR to 5.0?

[wtgodbe]

Combining this with #36231

[sebastienros]

I see the PR is still open #36231

[sebastienros]

Thanks @wtgodbe

[wtgodbe]

Is there more we need? I don't see anything obvious in main:

D:\workspace_work\1\s\src\Shared\E2ETesting\BrowserFixture.cs(324,36): error CS0246: The type or namespace name 'RemoteLogs' could not be found (are you missing a using directive or an assembly reference?) [D:\workspace_work\1\s\src\Components\test\E2ETest\Microsoft.AspNetCore.Components.E2ETests.csproj]

[sebastienros]

Didn't see these during my investigations

[wtgodbe]

Something from https://github.com/dotnet/aspnetcore/pull/36207/files? @SteveSandersonMS?

[wtgodbe]

Should we go back to 5a6101c and just skip Components E2E for now? What's the best way to do that?

[wtgodbe]

Might need https://github.com/dotnet/aspnetcore/pull/34045/files

[dougbu]

Is this more complicated than #36235 simply because we introduced Selenium tests in release/5.0❔ Do you need any help here from anyone❔

[wtgodbe]

Yes, selenium is the blocker here. I think whatever started causing 6.0 selenium tests to fail is also happening here, and I'm trying to piece together the right fixes from what we've done in main. Current commit might work, but if not I'm waiting to hear from @SteveSandersonMS or @javiercn on what the right thing to do is here (disable? some other fix I'm missing?)

[SteveSandersonMS]

Looks like the current commit did work. I checked the tests output and confirmed that the Components E2E tests did run here and they all passed. So, you might be fine as-is now!

It wouldn't be easy to backport all the changes I did for E2E test reliability to 5.0. For example, in 6.0 their CI run now happens on Linux in a separate pipeline to ensure there isn't anything else happening on the same machine at the same time. I expect making such sweeping changes to the 5.0 servicing branch would be out of scope.