Skip to content

[main] Update dependencies from dotnet/runtime dotnet/efcore #36328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Sep 21, 2021
Merged

[main] Update dependencies from dotnet/runtime dotnet/efcore #36328

merged 47 commits into from
Sep 21, 2021

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 9, 2021 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 32db3699-5666-45da-a1b7-08d8b804cd75
  • Build: 20210920.1
  • Date Produced: September 20, 2021 11:15:58 AM UTC
  • Commit: 6c9921d2ad188d81af53892930a87ee5ad97c979
  • Branch: refs/heads/main

From https://github.com/dotnet/efcore

  • Subscription: 8ce5251e-8269-419d-3b2a-08d8b8050dda
  • Build: 20210920.2
  • Date Produced: September 20, 2021 2:10:16 PM UTC
  • Commit: 29230f22c1f938e52133cc11e7e82668788a4697
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
6c34541 
…0909.1

Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.Win32.SystemEvents , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Logging.TraceSource , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Drawing.Common , System.DirectoryServices.Protocols , System.IO.Pipelines , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , System.ServiceProcess.ServiceController , System.Security.Permissions , System.Security.Cryptography.Xml , System.Security.Cryptography.Pkcs , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json , System.Text.Encodings.Web
 From Version 7.0.0-alpha.1.21457.1 -> To Version 7.0.0-alpha.1.21459.1
@dotnet-maestro dotnet-maestro bot requested a review from dougbu as a code owner September 9, 2021 12:09
@ghost ghost added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼 labels Sep 9, 2021
ghost
ghost approved these changes Sep 9, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
90c9c77 
…909.3

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21458.26 -> To Version 7.0.0-alpha.1.21459.3
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Sep 9, 2021
@wtgodbe
Copy link
Member

wtgodbe commented Sep 9, 2021

This is the one where we upgrade to net7.0, time to have some fun

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
74cdc6e 
…0910.1

Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.DirectoryServices.Protocols , System.Drawing.Common , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json , System.IO.Pipelines , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController
 From Version 7.0.0-alpha.1.21457.1 -> To Version 7.0.0-alpha.1.21460.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Sep 10, 2021
@pranavkm
Copy link
Contributor

I gave updating a try and it looks like the ref assemblies in the 7.0 Microsoft.NETCore.App ref pack are still using the 6.0 version.

e.g.

// D:\temp\buildops\aspnetcore\.dotnet\packs\Microsoft.NETCore.App.Ref\7.0.0-alpha.1.21425.4\ref\net6.0\System.Runtime.dll
// System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a

Perhaps the runtime versions haven't been completely updated. @wtgodbe who'd be the right person to ping about this?

@dougbu
Copy link
Member

dougbu commented Sep 10, 2021

I gave updating a try and it looks like the ref assemblies in the 7.0 Microsoft.NETCore.App ref pack are still using the 6.0 version.

e.g.

// D:\temp\buildops\aspnetcore\.dotnet\packs\Microsoft.NETCore.App.Ref\7.0.0-alpha.1.21425.4\ref\net6.0\System.Runtime.dll
// System.Runtime, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a

Perhaps the runtime versions haven't been completely updated. @wtgodbe who'd be the right person to ping about this?

@ericstj @ViktorHofer

@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
b4067b9 
…911.5

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21458.26 -> To Version 7.0.0-alpha.1.21461.5
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Sep 11, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
a94695c 
…0910.17

Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.DirectoryServices.Protocols , System.Drawing.Common , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json , System.IO.Pipelines , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController
 From Version 7.0.0-alpha.1.21457.1 -> To Version 7.0.0-alpha.1.21460.17
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/runtime dotnet/efcore [main] Update dependencies from dotnet/efcore dotnet/runtime Sep 11, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
c759378 
…0911.7

Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.DirectoryServices.Protocols , System.Drawing.Common , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json , System.IO.Pipelines , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController
 From Version 7.0.0-alpha.1.21457.1 -> To Version 7.0.0-alpha.1.21461.7
@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2021…
22b52b6 
…0913.1

Microsoft.Win32.SystemEvents , Microsoft.NETCore.Platforms , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.App.Runtime.win-x64 , System.Diagnostics.EventLog , System.Diagnostics.DiagnosticSource , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.Extensions.Primitives , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging , Microsoft.Extensions.Http , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Hosting , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Ref , System.DirectoryServices.Protocols , System.Drawing.Common , System.Runtime.CompilerServices.Unsafe , System.Resources.Extensions , System.Reflection.Metadata , System.Net.Http.WinHttpHandler , System.Net.Http.Json , System.IO.Pipelines , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.Windows.Extensions , System.Threading.Channels , System.Text.Json , System.Text.Encodings.Web , System.ServiceProcess.ServiceController
 From Version 7.0.0-alpha.1.21457.1 -> To Version 7.0.0-alpha.1.21463.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
20f5dd0 
…913.1

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21458.26 -> To Version 7.0.0-alpha.1.21463.1
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Sep 13, 2021
@wtgodbe
Copy link
Member

wtgodbe commented Sep 13, 2021

Looks like the runtime/ref packs have been updated to have the net7.0 TFM. Diving in

@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/efcore dotnet/runtime [main] Update dependencies from dotnet/runtime dotnet/efcore Sep 20, 2021
@dotnet-maestro
Update dependencies from https://github.com/dotnet/efcore build 20210…
7a6b6be 
…920.2

Microsoft.EntityFrameworkCore.Tools , dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.Design
 From Version 7.0.0-alpha.1.21458.26 -> To Version 7.0.0-alpha.1.21470.2
@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2021

Oh, the payload has the generated directory.build.x files at the root, but in the RunTests folder where RunTests.csproj lives/runs, there are empty directory.build.x files that don't import the ones above them, so we don't get any of the workarounds. @HaoK is that on purpose? I'm digging around now

@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2021

Yep: https://github.com/dotnet/aspnetcore/blob/8b30d862de6c9146f466061d51aa3f1414ee2337/eng/helix/content/RunTests/Directory.Build.targets

So these should import the files above them. Adding that now

@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2021

Internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1372549&view=results

@dougbu
Copy link
Member

dougbu commented Sep 20, 2021 •
edited
Loading

So these should import the files above them. Adding that now

@BrennanConroy introduced the eng/helix/content/Runtest/Directory.Build.* files in ca5cd91 That predates 219ecd6 by a fair amount. All 219ecd6 did was switch from <Project></Project> to <Project />.

In any case, the idea was to completely isolate RunTests from whatever Directory.Build.* files exist in the work item root. The project should build against a runtime and references built into the SDK.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2021

In any case, the idea was to completely isolate RunTests from whatever Directory.Build.* files exist in the work item root. The project should build against a runtime and references built into the SDK.

Oh, so runtests itself should run without the workarounds, and it launches the tests which do get the workarounds? In that case I think we just need to treat runtests like RepoTasks (keep it at net6.0 for now)

@dougbu
Copy link
Member

dougbu commented Sep 20, 2021

In that case I think we just need to treat runtests like RepoTasks (keep it at net6.0 for now)

Yeah, that's what we did in 219ecd6 too i.e. it's how we handled the TFM-before-SDK bridge the last time around

@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2021

https://dev.azure.com/dnceng/internal/_build/results?buildId=1372813&view=results

@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2021 •
edited
Loading

Nice, we're down to a few (real looking) test failures

Templates.Test.BaselineTest.Template_Produces_The_Right_Set_Of_FilesAsync(arguments: "new react", expectedFiles: ["ClientApp/public/favicon.ico", "ClientApp/public/index.html", "ClientApp/public/manifest.json", "ClientApp/src/components/Counter.js", "ClientApp/src/components/FetchData.js", ...])

Expected file to exist, but it doesn't: ClientApp/src/reportWebVitals.js

Microsoft.AspNetCore.Mvc.FunctionalTests.HtmlGenerationTest.CacheTagHelper_BubblesExpirationOfNestedTagHelpers

Assert.Equal() Failure
↓ (pos 33)
Expected: ···ctronics
Products: Music Systems, Televisions (3)
Actual: ···ctronics
Products: Book1, Book2 (1)
↑ (pos 33)

Microsoft.AspNetCore.Mvc.TagHelpers.CacheTagHelperTest.ProcessAsync_FlowsEntryLinkThatAllowsAddingTriggersToAddedEntry

Assert.False() Failure
Expected: False
Actual: True
at Microsoft.AspNetCore.Mvc.TagHelpers.CacheTagHelperTest.ProcessAsync_FlowsEntryLinkThatAllowsAddingTriggersToAddedEntry() in /_/src/Mvc/Mvc.TagHelpers/test/CacheTagHelperTest.cs:line 539

@pranavkm any ideas here? Should we just quarantine these for now?

@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2021

CC also @javiercn for the failing MVC/template tests - these things are pretty ancient, not sure why updating the TFM would cause them to fail. Can we disable them pending an investigation?

@pranavkm
Copy link
Contributor

Could you skip the tests if the failure is persistent? It might be a runtime bug, but we could investigate the failures without holding up this PR

@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2021

Could you skip the tests if the failure is persistent? It might be a runtime bug, but we could investigate the failures without holding up this PR

I'll do that - the failures are consistent, the tests failed on all 3 helix queues on both the public & internal builds.

@wtgodbe
Copy link
Member

wtgodbe commented Sep 20, 2021

@HaoK what should we do about this test (which is failing):

aspnetcore/src/ProjectTemplates/test/BaselineTest.cs

Lines 69 to 72 in 493ed8b

// This test should generally not be quarantined as it only is checking that the expected files are on disk
[Theory]
[MemberData(nameof(TemplateBaselines))]
public async Task Template_Produces_The_Right_Set_Of_FilesAsync(string arguments, string[] expectedFiles)

@halter73
Copy link
Member

It looks like Template_Produces_The_Right_Set_Of_FilesAsync was failing because src/submodules/spa-templates got reverted to an earlier commit. I think a47c0a5 (#36328) should fix it.

@halter73
Copy link
Member

@wtgodbe If this build passes, I'm merging despite your requested changes since I'm assuming that's stale.

@dotnet-maestro dotnet-maestro bot merged commit 70c05f1 into main Sep 21, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-c944b2c3-1c63-49a3-b9dd-98cda1a942e3 branch September 21, 2021 02:28
@ghost ghost added this to the 7.0-preview1 milestone Sep 21, 2021
@dougbu dougbu mentioned this pull request Sep 21, 2021
Merged
@javiercn
Copy link
Member

@wtgodbe did you file an issue for the problematic tests?

@wtgodbe
Copy link
Member

wtgodbe commented Sep 21, 2021

Yes, #36765

@halter73 halter73 restored the darc-main-c944b2c3-1c63-49a3-b9dd-98cda1a942e3 branch October 19, 2021 00:59
@halter73 halter73 deleted the darc-main-c944b2c3-1c63-49a3-b9dd-98cda1a942e3 branch October 19, 2021 00:59
dougbu pushed a commit to dougbu/razor-compiler that referenced this pull request Nov 17, 2021
@dotnet-maestro
[main] Update dependencies from dotnet/runtime dotnet/efcore (dotnet/…
744ae71 
…aspnetcore#36328)

[main] Update dependencies from dotnet/runtime dotnet/efcore


 - Update TFM to net7.0

 - Fixup

 - Update src/Shared/CodeAnalysis/DynamicallyAccessedMembersAttribute.cs

Co-authored-by: Chris Ross <[email protected]>

 - Update src/Shared/CodeAnalysis/DynamicallyAccessedMemberTypes.cs

Co-authored-by: Chris Ross <[email protected]>

 - Update netfx to 462

 - Update more to net462

 - Fix workaround

 - Update ifdefs

 - Add workaround for KnownRuntimePack

 - Merge branch 'darc-main-c944b2c3-1c63-49a3-b9dd-98cda1a942e3' of https://github.com/dotnet/aspnetcore into darc-main-c944b2c3-1c63-49a3-b9dd-98cda1a942e3

 - Merge branch 'main' into darc-main-c944b2c3-1c63-49a3-b9dd-98cda1a942e3

 - Add SiteExtensions versions

 - Fix RepoTasks assembly dir

 - Update CreateFrameworkListFile to account for new analyzer path format introduced with dotnet/sdk#20355

 - Don't target latest runtime in razor tests

 - Update Dependencies.props

 - Update Helix.targets

 - Fixup

 - Move FrameworkReference update to GenerateFiles

 - Have Helix tests import directory.build files

 - Keep RunTests at net6

 - Quarantine 2 tests

 - revert spa-templates submodule downgrade

Commit migrated from dotnet/aspnetcore@70c05f178a33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViktorHofer ViktorHofer ViktorHofer left review comments

@eerhardt eerhardt eerhardt left review comments

@Tratcher Tratcher Tratcher approved these changes

@dougbu dougbu dougbu approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

@captainsafia captainsafia Awaiting requested review from captainsafia captainsafia is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@mkArtakMSFT mkArtakMSFT Awaiting requested review from mkArtakMSFT mkArtakMSFT is a code owner

@Pilchie Pilchie Awaiting requested review from Pilchie

@javiercn javiercn Awaiting requested review from javiercn

@pranavkm pranavkm Awaiting requested review from pranavkm

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.
10 participants
@wtgodbe @pranavkm @dougbu @eerhardt @Pilchie @HaoK @halter73 @javiercn @Tratcher @ViktorHofer