Add support for BindAsync without ParameterInfo #36505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
the
old-area-web-frameworks-do-not-use
BrennanConroy
requested review from
halter73,
Pilchie and
Tratcher
as code owners
davidfowl
reviewed
Sep 15, 2021
Co-authored-by: David Fowler <[email protected]>
BrennanConroy
commented
Sep 15, 2021
BrennanConroy
commented
Sep 15, 2021
| @@ -128,12 +131,18 @@ public bool HasTryParseMethod(ParameterInfo parameter) | |||
| return _stringMethodCallCache.GetOrAdd(type, Finder); | |||
| } | |||
|
|
|||
| public Expression? FindBindAsyncMethod(ParameterInfo parameter) | |||
| public (Expression?, int) FindBindAsyncMethod(ParameterInfo parameter) | |||
There was a problem hiding this comment.
Suggested change
| public (Expression?, int) FindBindAsyncMethod(ParameterInfo parameter) | |
| public (Expression? Expression, int ParamCount) FindBindAsyncMethod(ParameterInfo parameter) |
Would this be better @davidfowl ?
There was a problem hiding this comment.
I don't think this changed much but it's fine
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1239549193 |
davidfowl
approved these changes
Sep 15, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36415
Prefers
BindAsync(HttpContext, ParameterInfo)overBindAsync(HttpContext).