[release/6.0-rc2] Add support for BindAsync without ParameterInfo #36590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
BrennanConroy,
Pilchie and
Tratcher
as code owners
BrennanConroy
added
the
old-area-web-frameworks-do-not-use
|
@Pilchie Are we in tell mode or do we need to go to tactics? |
|
We're in M2 approval mode, so you need to tag me. You're ok to merge this change. |
BrennanConroy
changed the title
captainsafia
approved these changes
Sep 16, 2021
|
@dotnet/aspnet-build Would someone be willing to merge this? OnValidateIdentityDoesNotExtendExpirationWhenSlidingIsDisabled failed but is being fixed in #36626 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #36580 to release/6.0-rc2
/cc @BrennanConroy @github-actions[bot]
Customer Impact
Users who write a
BindAsyncmethod on their class to override parsing logic may see a VS info/warning to remove theParameterInfoparameter from the method because they didn't use it. This would then break the behavior becauseBindAsyncwithout aParameterInfowouldn't match theBindAsyncwe're looking for. Or the user will need to suppress or ignore the recommendation to remove the unused param.Testing
Good test coverage for old and new behavior and checking that the fallback works correctly.
Risk
Low, we are adding a fallback to a working scenario and there is very little risk that something broke.