Skip to content

[automated] Merge branch 'release/6.0-rc2' => 'release/6.0' #36657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e603852
[release/6.0-rc2] Update dependencies from dotnet/efcore (#36635)
dotnet-maestro[bot] Sep 17, 2021
facd7d2
[release/6.0-rc2] Handle JsonExceptions in RequestDelegateFactory (#3…
halter73 Sep 17, 2021
b16aa3d
[release/6.0-rc2] Update dependencies from dotnet/runtime dotnet/efco…
dotnet-maestro[bot] Sep 17, 2021
87769fc
Avoid using invalid content type for ValidationProblemDetails (#36618)
github-actions[bot] Sep 17, 2021
5363da3
Update dependencies from https://github.com/dotnet/efcore build 20210…
dotnet-maestro[bot] Sep 17, 2021
9401630
Use a fake clock in the test (#36626)
github-actions[bot] Sep 17, 2021
8e2d9d1
Update dependencies from https://github.com/dotnet/runtime build 2021…
dotnet-maestro[bot] Sep 17, 2021
9e496ff
[release/6.0-rc2] Throw for invalid TryParse and BindAsync (#36662)
github-actions[bot] Sep 17, 2021
07dddeb
Update dependencies from https://github.com/dotnet/efcore build 20210…
dotnet-maestro[bot] Sep 17, 2021
743d9bc
Revert Enforce WebSockets Transport for Blazor (#36656)
TanayParikh Sep 18, 2021
2e423d6
[release/6.0-rc2] Update dependencies from dotnet/runtime dotnet/efco…
dotnet-maestro[bot] Sep 18, 2021
d46ed8e
Update dependencies from https://github.com/dotnet/runtime build 2021…
dotnet-maestro[bot] Sep 18, 2021
41343f1
Update dependencies from https://github.com/dotnet/efcore build 20210…
dotnet-maestro[bot] Sep 18, 2021
e0b60e8
[release/6.0-rc2] Update dependencies from dotnet/efcore dotnet/runti…
dotnet-maestro[bot] Sep 18, 2021
a43284c
[Release/6.0-rc2] Fix and test HttpSys delegation (#36698)
Tratcher Sep 18, 2021
ebbc273
Update dependencies from https://github.com/dotnet/efcore build 20210…
dotnet-maestro[bot] Sep 18, 2021
49a2202
Find inherited TryParse and BindAsync (#36694)
github-actions[bot] Sep 20, 2021
8a1974d
[release/6.0-rc2] Use minimal APIs for F# project templates (#36660)
github-actions[bot] Sep 20, 2021
38452c0
[release/6.0-rc2] Retarget DOTNETHOME when installing x64 on ARM64 (#…
github-actions[bot] Sep 20, 2021
ba788d6
Pin analyzers that ship in the SDK (#36690) (#36754)
pranavkm Sep 20, 2021
a1ed65a
[release/6.0-rc2] Rename and consolidate "DelegateEndpoint" types (#…
halter73 Sep 20, 2021
a3bb88e
Call AddEndpointsApiExplorer() in controllers Web API template (#36753)
github-actions[bot] Sep 20, 2021
59b4f58
[release/6.0-rc2] Update dependencies from dotnet/efcore dotnet/runti…
dotnet-maestro[bot] Sep 21, 2021
4ab0cf3
Update dependencies from https://github.com/dotnet/efcore build 20210…
dotnet-maestro[bot] Sep 21, 2021
dd92f78
Merge branch 'release/6.0' into merge/release/6.0-rc2-to-release/6.0
halter73 Sep 21, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions AspNetCore.sln
Original file line number Diff line number Diff line change
Expand Up @@ -1656,6 +1656,10 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNetCore.App.Co
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Microsoft.AspNetCore.App.Analyzers.Test", "src\Framework\AspNetCoreAnalyzers\test\Microsoft.AspNetCore.App.Analyzers.Test.csproj", "{B739B8B6-94F5-4F05-9497-28A7C6EBBC03}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.AspNetCore.Server.HttpSys.NonHelixTests", "src\Servers\HttpSys\test\NonHelixTests\Microsoft.AspNetCore.Server.HttpSys.NonHelixTests.csproj", "{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "DelegationSite", "src\Servers\HttpSys\test\testassets\DelegationSite\DelegationSite.csproj", "{14217994-9F24-4E14-87B6-58367ED0413B}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -7907,6 +7911,30 @@ Global
{B739B8B6-94F5-4F05-9497-28A7C6EBBC03}.Release|x64.Build.0 = Release|Any CPU
{B739B8B6-94F5-4F05-9497-28A7C6EBBC03}.Release|x86.ActiveCfg = Release|Any CPU
{B739B8B6-94F5-4F05-9497-28A7C6EBBC03}.Release|x86.Build.0 = Release|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Debug|Any CPU.Build.0 = Debug|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Debug|x64.ActiveCfg = Debug|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Debug|x64.Build.0 = Debug|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Debug|x86.ActiveCfg = Debug|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Debug|x86.Build.0 = Debug|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Release|Any CPU.ActiveCfg = Release|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Release|Any CPU.Build.0 = Release|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Release|x64.ActiveCfg = Release|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Release|x64.Build.0 = Release|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Release|x86.ActiveCfg = Release|Any CPU
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1}.Release|x86.Build.0 = Release|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Debug|Any CPU.Build.0 = Debug|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Debug|x64.ActiveCfg = Debug|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Debug|x64.Build.0 = Debug|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Debug|x86.ActiveCfg = Debug|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Debug|x86.Build.0 = Debug|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Release|Any CPU.ActiveCfg = Release|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Release|Any CPU.Build.0 = Release|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Release|x64.ActiveCfg = Release|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Release|x64.Build.0 = Release|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Release|x86.ActiveCfg = Release|Any CPU
{14217994-9F24-4E14-87B6-58367ED0413B}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -8727,6 +8755,8 @@ Global
{636B73F6-9EED-435D-9DA8-EB3C7FDFAB1C} = {23C56C5B-9D3F-4069-88C4-87ACCFE05DBC}
{78D9A5AF-6089-44F4-93AB-F7E96925E4FD} = {23C56C5B-9D3F-4069-88C4-87ACCFE05DBC}
{B739B8B6-94F5-4F05-9497-28A7C6EBBC03} = {12541C41-58FB-46F4-BA0F-0D56B5B45A18}
{37BDB2D5-EEEC-48C9-A7AD-5A2A73BD31B1} = {C3722C5D-E159-4AB3-AF60-769185B31B47}
{14217994-9F24-4E14-87B6-58367ED0413B} = {C3722C5D-E159-4AB3-AF60-769185B31B47}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {3E8720B3-DBDD-498C-B383-2CC32A054E8F}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ public static ComponentEndpointConventionBuilder MapBlazorHub(
throw new ArgumentNullException(nameof(path));
}

// Only support the WebSockets transport type by default
return endpoints.MapBlazorHub(path, configureOptions: options => { options.Transports = HttpTransportType.WebSockets; });
return endpoints.MapBlazorHub(path, configureOptions: _ => { });
}

/// <summary>
Expand Down
2 changes: 1 addition & 1 deletion src/Components/Web.JS/dist/Release/blazor.server.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/Components/Web.JS/dist/Release/blazor.webview.js

Large diffs are not rendered by default.

19 changes: 3 additions & 16 deletions src/Components/Web.JS/src/Boot.Server.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { DotNet } from '@microsoft/dotnet-js-interop';
import { Blazor } from './GlobalExports';
import { HubConnectionBuilder, HubConnection, HttpTransportType } from '@microsoft/signalr';
import { HubConnectionBuilder, HubConnection } from '@microsoft/signalr';
import { MessagePackHubProtocol } from '@microsoft/signalr-protocol-msgpack';
import { showErrorNotification } from './BootErrors';
import { shouldAutoStart } from './BootCommon';
Expand Down Expand Up @@ -86,7 +86,7 @@ async function initializeConnection(options: CircuitStartOptions, logger: Logger
(hubProtocol as unknown as { name: string }).name = 'blazorpack';

const connectionBuilder = new HubConnectionBuilder()
.withUrl('_blazor', HttpTransportType.WebSockets)
.withUrl('_blazor')
.withHubProtocol(hubProtocol);

options.configureSignalR(connectionBuilder);
Expand Down Expand Up @@ -144,14 +144,7 @@ async function initializeConnection(options: CircuitStartOptions, logger: Logger
// Throw this exception so it can be handled at the reconnection layer, and don't show the
// error notification.
throw ex;
} else if (!isNestedError(ex)) {
showErrorNotification();
} else if (ex.innerErrors && ex.innerErrors.some(e => e.errorType === 'UnsupportedTransportError' && e.transport === HttpTransportType.WebSockets)) {
showErrorNotification('Unable to connect, please ensure you are using an updated browser that supports WebSockets.');
} else if (ex.innerErrors && ex.innerErrors.some(e => e.errorType === 'FailedToStartTransportError' && e.transport === HttpTransportType.WebSockets)) {
showErrorNotification('Unable to connect, please ensure WebSockets are available. A VPN or proxy may be blocking the connection.');
} else if (ex.innerErrors && ex.innerErrors.some(e => e.errorType === 'DisabledTransportError' && e.transport === HttpTransportType.LongPolling)) {
logger.log(LogLevel.Error, 'Unable to initiate a SignalR connection to the server. This might be because the server is not configured to support WebSockets. To troubleshoot this, visit https://aka.ms/blazor-server-websockets-error.');
} else {
showErrorNotification();
}
}
Expand All @@ -169,14 +162,8 @@ async function initializeConnection(options: CircuitStartOptions, logger: Logger
});

return connection;

function isNestedError(error: any): error is AggregateError {
return error && ('innerErrors' in error);
}
}

type AggregateError = Error & { innerErrors: { errorType: string, transport: HttpTransportType }[] };

function unhandledError(connection: HubConnection, err: Error, logger: Logger): void {
logger.log(LogLevel.Error, err);

Expand Down
6 changes: 1 addition & 5 deletions src/Components/Web.JS/src/BootErrors.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
let hasFailed = false;

export async function showErrorNotification(customErrorMessage: string = '') {
export async function showErrorNotification() {
let errorUi = document.querySelector('#blazor-error-ui') as HTMLElement;
if (errorUi) {
errorUi.style.display = 'block';

if (customErrorMessage && errorUi.firstChild) {
errorUi.firstChild.textContent = `\n\t${customErrorMessage}\t\n`;
}
}

if (!hasFailed) {
Expand Down

This file was deleted.

69 changes: 0 additions & 69 deletions src/Components/test/testassets/TestServer/Pages/Transports.cshtml

This file was deleted.

2 changes: 1 addition & 1 deletion src/Components/test/testassets/TestServer/ServerStartup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public void ConfigureServices(IServiceCollection services)
}

// This method gets called by the runtime. Use this method to configure the HTTP request pipeline.
public virtual void Configure(IApplicationBuilder app, IWebHostEnvironment env, ResourceRequestLog resourceRequestLog)
public void Configure(IApplicationBuilder app, IWebHostEnvironment env, ResourceRequestLog resourceRequestLog)
{
var enUs = new CultureInfo("en-US");
CultureInfo.DefaultThreadCurrentCulture = enUs;
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
using Microsoft.CodeAnalysis.Diagnostics;
using Microsoft.CodeAnalysis.Operations;

namespace Microsoft.AspNetCore.Analyzers.DelegateEndpoints;
namespace Microsoft.AspNetCore.Analyzers.RouteHandlers;

public partial class DelegateEndpointAnalyzer : DiagnosticAnalyzer
public partial class RouteHandlerAnalyzer : DiagnosticAnalyzer
{
internal const string DetectMismatchedParameterOptionalityRuleId = "ASP0006";

Expand Down
Loading