Fix and test HttpSys delegation #36677
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using System.Net.Http; | ||
| using Microsoft.AspNetCore.Server.IntegrationTesting; | ||
| using Microsoft.AspNetCore.Testing; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace Microsoft.AspNetCore.Server.HttpSys.NonHelixTests | ||
|
There was a problem hiding this comment. Is there a reason why we don't want these to run on helix? There was a problem hiding this comment. We never figured out how to make them work there. #8247 |
||
| { | ||
| public class DelegateOutOfProcTests : LoggedTest | ||
| { | ||
| public DelegateOutOfProcTests(ITestOutputHelper output) : base(output) { } | ||
|
|
||
| [ConditionalFact] | ||
| [DelegateSupportedCondition(true)] | ||
| public async Task CanDelegateOutOfProcess() | ||
| { | ||
| using var _ = StartLog(out var loggerFactory); | ||
|
|
||
| var logger = loggerFactory.CreateLogger("CanDelegateOutOfProcess"); | ||
|
|
||
| // https://github.com/dotnet/aspnetcore/issues/8247 | ||
| #pragma warning disable 0618 | ||
| var applicationPath = Path.Combine(TestPathUtilities.GetSolutionRootDirectory("HttpSysServer"), "test", "testassets", | ||
| "DelegationSite"); | ||
| #pragma warning restore 0618 | ||
|
|
||
| var deploymentParameters = new DeploymentParameters( | ||
| applicationPath, | ||
| ServerType.HttpSys, | ||
| RuntimeFlavor.CoreClr, | ||
| RuntimeArchitecture.x64) | ||
| { | ||
| EnvironmentName = "Testing", | ||
| TargetFramework = Tfm.Default, | ||
| ApplicationType = ApplicationType.Portable, | ||
| PublishApplicationBeforeDeployment = true, | ||
| StatusMessagesEnabled = true | ||
| }; | ||
|
|
||
| var queueName = Guid.NewGuid().ToString(); | ||
| deploymentParameters.EnvironmentVariables["queue"] = queueName; | ||
|
|
||
| using var deployer = new SelfHostDeployer(deploymentParameters, loggerFactory); | ||
| var deploymentResult = await deployer.DeployAsync().DefaultTimeout(); | ||
|
|
||
| // Make sure the deployment really worked | ||
| var responseString = await deploymentResult.HttpClient.GetStringAsync("").DefaultTimeout(); | ||
| Assert.Equal("Hello from delegatee", responseString); | ||
|
|
||
| DelegationRule destination = default; | ||
| using var delegator = Utilities.CreateHttpServer(out var delegatorAddress, httpContext => | ||
| { | ||
| var delegateFeature = httpContext.Features.Get<IHttpSysRequestDelegationFeature>(); | ||
| delegateFeature.DelegateRequest(destination); | ||
| return Task.CompletedTask; | ||
| }); | ||
|
|
||
| var delegationProperty = delegator.Features.Get<IServerDelegationFeature>(); | ||
| using (destination = delegationProperty.CreateDelegationRule(queueName, deploymentResult.ApplicationBaseUri)) | ||
| { | ||
| // Send a request to the delegator that gets transfered to the delegatee in the other process. | ||
| using var client = new HttpClient(); | ||
| responseString = await client.GetStringAsync(delegatorAddress).DefaultTimeout(); | ||
| Assert.Equal("Hello from delegatee", responseString); | ||
| } | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happen on older OSes that don't have this API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTTP_INITIALIZE_CONFIG isn't a new flag, I think it's been around forever. What changed is that HttpIsFeatureSupported now requires it.