Remove continueOnBuildError for components E2E tests. Fixes #35565 #36839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
javiercn
approved these changes
Sep 22, 2021
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1262341496 |
wtgodbe
approved these changes
Sep 22, 2021
|
/azp run all |
|
No pipelines are associated with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The components E2E tests have been very stable since I did a bunch of work to change how they run in CI (e.g., on Linux and without parallelism, and with retries). See the run history: https://dev.azure.com/dnceng/public/_build?definitionId=1026.
Since those changes, I haven't seen any cases where tests failed incorrectly. I haven't personally inspected every build, but all the failures I've seen have all been legit build issues, not test issues.
So it's now time to remove the "ignore failures" flag, and fix #35565