Skip to content

Update CONTRIBUTING.md #37696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 22, 2021
Merged

Update CONTRIBUTING.md #37696

merged 4 commits into from
Oct 22, 2021

Conversation

subramanir2143
Copy link
Contributor

@subramanir2143 subramanir2143 commented Oct 20, 2021 •
edited
Loading

{PR title}

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 20, 2021
@dnfadmin
Copy link

dnfadmin commented Oct 20, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

Pilchie
Pilchie approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@Pilchie Pilchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkArtakMSFT - you might want to take a look too

@Pilchie Pilchie added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Oct 20, 2021
@Pilchie Pilchie requested a review from mkArtakMSFT October 20, 2021 15:35
dougbu
dougbu reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits and one part remains troublesome

@dougbu dougbu merged commit de9923e into dotnet:main Oct 22, 2021
@ghost ghost added this to the 7.0-preview1 milestone Oct 22, 2021
@dougbu
Copy link
Contributor

dougbu commented Oct 22, 2021

Many thanks @subramanir2143❕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia left review comments

@Pilchie Pilchie Pilchie approved these changes

@dougbu dougbu dougbu approved these changes

@mkArtakMSFT mkArtakMSFT Awaiting requested review from mkArtakMSFT

Assignees

@dougbu dougbu

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
7.0-preview1
Development

Successfully merging this pull request may close these issues.
5 participants
@subramanir2143 @dnfadmin @dougbu @Pilchie @captainsafia