[wasm] dotnet.js modularization #38721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pavelsavara
force-pushed
the
wasm_modularization_1
branch
2 times, most recently
from
c75d9df to
ea7f1ae
Compare
|
cc @lewing |
pavelsavara
force-pushed
the
wasm_modularization_1
branch
4 times, most recently
from
947b7d5 to
aa2ce47
Compare
pavelsavara
force-pushed
the
wasm_modularization_1
branch
2 times, most recently
from
c180d9e to
e9bf748
Compare
pavelsavara
requested review from
TanayParikh,
pranavkm,
mkArtakMSFT and
SteveSandersonMS
pavelsavara
changed the title
dougbu
reviewed
Dec 20, 2021
- updated createEmscriptenModuleInstance to use the new createDotnetRuntime() API - removed @types/emscripten type definitions - added src/Components/Web.JS/@types/dotnet temporarily, until we figure out how to pull this out of Microsoft.NETCore.App.Runtime.Mono.browser-wasm.7.0.0-dev.nupkg - fixed usages of addRunDependency, removeRunDependency - mapped System_Object and other types to MonoObject etc - global Module is no longer needed by runtime - therefore removed __wasmmodulecallback__ - removed few cwrap calls and replaced them with API usage
pavelsavara
force-pushed
the
wasm_modularization_1
branch
from
1229563 to
6ba858e
Compare
wtgodbe
approved these changes
Dec 21, 2021
# Conflicts: # src/Components/Web.JS/dist/Release/blazor.server.js # src/Components/Web.JS/dist/Release/blazor.webview.js # src/Components/Web.JS/src/Platform/Mono/MonoTypes.ts # src/Components/Web.JS/src/Platform/Platform.ts
TanayParikh
reviewed
Jan 3, 2022
|
Thanks @pavelsavara - I think we're just about there! I added a couple of substantive comments about the new link modulepreload code, plus a bunch of trivial syntax tweak suggestions. Hope that's OK. Once that's resolved I think this can be merged! |
Co-authored-by: Steve Sanderson <[email protected]>
Co-authored-by: Steve Sanderson <[email protected]>
Co-authored-by: Steve Sanderson <[email protected]>
Co-authored-by: Steve Sanderson <[email protected]>
Co-authored-by: Steve Sanderson <[email protected]>
Co-authored-by: Steve Sanderson <[email protected]>
Co-authored-by: Steve Sanderson <[email protected]>
SteveSandersonMS
approved these changes
Jan 11, 2022
|
Hello @SteveSandersonMS! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
There is some issue with IIS test, I think it's unrelated and it could be merged. |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After dotnet.js was modularized, Blazor could start using the new API we expose.
This PR updates Blazor to use new API createDotnetRuntime()
The current default output of runtime is CommonJS module, which is at the same time backward compatible with .NET 6.0
globalThis.Modulestyle. In the future ES6 would be default module format. This change also makes Blazor future-compatible with ES6 runtime module.Changes
use dynamic
importinstead of HTML<script>tag to load dotnetupdated
createEmscriptenModuleInstanceto use the newcreateDotnetRuntime()APImade import of dotnet.js parallel with loading other assets.
added
src/Components/Web.JS/@types/dotnettemporarily, until we figure out how to pull this out ofMicrosoft.NETCore.App.Runtime.Mono.browser-wasm.7.0.0-dev.nupkgremoved @types/emscripten type definitions
fixed usages of
addRunDependency,removeRunDependencymapped
System_Objectand other types toMonoObjectetcglobal
Moduleis no longer needed by runtime__wasmmodulecallback__because it's not ES6 yet
__onDotnetRuntimeLoadedto get the API when the CJS module is loadedremoved few
cwrapcalls and replaced them with API usageImplemented DRI for dynamic import via link
modulepreloadFeedback
This is also opportunity for Blazor team to give feedback about the new API.
There are more samples of the API usage here dotnet/runtime#62292
Fixes #39283
Fixes: #36805