Skip to content

Unquarantine tests / skip mslocaldb helix tests #38814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/test-configuration.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
{"testName": {"contains": "CheckStdoutWithLargeWrites"}},
{"testName": {"contains": "ServerShutsDownWhenMainExitsStress" }},
{"testName": {"contains": "AddressRegistrationTests" }},
{"testName": {"contains": "MaxRequestBufferSizeTests.LargeUpload" }},
{"failureMessage": "network disconnected" }
],
"failOnRules": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
<SignAssembly>false</SignAssembly>
<AssemblyName>Diagnostics.FunctionalTests</AssemblyName>
<TestDependsOnMssql>true</TestDependsOnMssql>

<!-- https://github.com/dotnet/aspnetcore/issues/38819 LocalDb sometimes hangs on win11 helix queue -->
<BuildHelixPayload>false</BuildHelixPayload>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ public async Task RollsTextFilesBasedOnDate()
}
}

[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/34284")]
[Fact]
public async Task RollsTextFilesBasedOnSize()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
<BaseOutputPath />
<OutputPath />

<!-- https://github.com/dotnet/aspnetcore/issues/38818 -->
<BuildHelixPayload>false</BuildHelixPayload>

<!-- Properties that affect test runs -->
<!-- TestTemplateCreationFolder is the folder where the templates will be created. Will point out to $(OutputDir)$(TestTemplateCreationFolder) -->
<TestTemplateCreationFolder>TestTemplates\</TestTemplateCreationFolder>
Expand Down
1 change: 0 additions & 1 deletion src/ProjectTemplates/test/BlazorServerTemplateTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ public BlazorServerTemplateTest(ProjectFactoryFixture projectFactory)
[InlineData("SingleOrg", null)]
[InlineData("SingleOrg", new string[] { "--called-api-url \"https://graph.microsoft.com\"", "--called-api-scopes user.readwrite" })]
[InlineData("SingleOrg", new string[] { "--calls-graph" })]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/30882")]
public Task BlazorServerTemplate_IdentityWeb_BuildAndPublish(string auth, string[] args)
=> CreateBuildPublishAsync("blazorserveridweb" + Guid.NewGuid().ToString().Substring(0, 10).ToLowerInvariant(), auth, args);

Expand Down
1 change: 0 additions & 1 deletion src/ProjectTemplates/test/RazorPagesTemplateTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ public async Task RazorPagesTemplate_IndividualAuth(bool useLocalDB)

[ConditionalTheory]
[InlineData("SingleOrg", new string[] { "--calls-graph" })]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/31729")]
public Task RazorPagesTemplate_IdentityWeb_BuildsAndPublishes_WithSingleOrg(string auth, string[] args) => BuildAndPublishRazorPagesTemplate(auth: auth, args: args);

private async Task<Project> BuildAndPublishRazorPagesTemplate(string auth, string[] args)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ from ssl in sslValues
}
[Theory]
[MemberData(nameof(LargeUploadData))]
[QuarantinedTest("This is inherently flaky and should never be unquarantined.")]
// This is inherently flaky and is relying on helix retry to pass consistently
public async Task LargeUpload(long? maxRequestBufferSize, bool connectionAdapter, bool expectPause)
{
// Parameters
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ public ResponseTrailersWrapper(IHeaderDictionary headers)
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/37930")]
public async Task ResponseTrailers_MultipleStreams_Reset()
{
IEnumerable<KeyValuePair<string, string>> requestHeaders = new[]
Expand Down