Use non-generic TaskCompletionSource #39835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the non-generic TaskCompletionSource where appropriate.
ghost
added
the
community-contribution
Member
|
General note: Mass modifying test code for something like this isn't generally interesting or useful. If there is product code that could be updated that is useful (and I see there are a couple in this PR). |
Member
Author
|
@BrennanConroy Noted for future reference 👍 - shall I trim this down just to the product code updates? |
Pilchie
added
area-blazor
pranavkm
approved these changes
Jan 28, 2022
src/Servers/IIS/IIS/test/testassets/InProcessWebSite/Startup.cs
Outdated
Show resolved
Hide resolved
pranavkm
reviewed
Jan 28, 2022
src/Servers/IIS/IIS/test/testassets/InProcessWebSite/Startup.cs
Outdated
Show resolved
Hide resolved
pranavkm
requested review from
a team,
BrennanConroy,
Pilchie,
Tratcher,
halter73 and
javiercn
as code owners
amcasey
added
area-middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use non-generic TaskCompletionSource
Use the non-generic
TaskCompletionSourcewhere appropriate.Description
Inspired by dotnet/runtime#64423, I had a look to see if there were any usages of
TaskCompletionSource<T>that could just use the non generic variant instead. Searching forbool,intandobjectI found quite a few, mostly in tests, which were just being used to signal completion of arbitrary operation where theTvalue wasn't used.This PR changes all such usages that wouldn't require use of conditional compilation to handle TFMs that don't have support for
TaskCompletionSource.I've left this as a draft for now because it touches a lot of files so it doesn't create a notification deluge. If this change isn't welcome (or is too big), I can just close it (or amend it).