Adding support to infer FromServices parameters #39926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
TanayParikh
added
old-area-web-frameworks-do-not-use
pranavkm
approved these changes
Feb 3, 2022
| @@ -39,12 +41,23 @@ public class ApiBehaviorOptions : IEnumerable<ICompatibilitySwitch> | |||
| /// When enabled, the following sources are inferred: | |||
| /// Parameters that appear as route values, are assumed to be bound from the path (<see cref="BindingSource.Path"/>). | |||
| /// Parameters of type <see cref="IFormFile"/> and <see cref="IFormFileCollection"/> are assumed to be bound from form. | |||
| /// Parameters that are complex (<see cref="ModelMetadata.IsComplexType"/>) and are registered in the DI Container (<see cref="IServiceCollection"/>) are assumed to be bound from the services <see cref="BindingSource.Services"/>, unless this | |||
There was a problem hiding this comment.
Is the precedence order the same in minimal i.e is IServiceProviderIsService only used for complex types?
src/Mvc/Mvc.Core/src/ApplicationModels/ApiBehaviorApplicationModelProvider.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/ApplicationModels/InferParameterBindingInfoConvention.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/ApplicationModels/InferParameterBindingInfoConvention.cs
Outdated
Show resolved
Hide resolved
pranavkm
approved these changes
Feb 7, 2022
src/Mvc/Mvc.Core/src/ApplicationModels/InferParameterBindingInfoConvention.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/ApplicationModels/InferParameterBindingInfoConvention.cs
Outdated
Show resolved
Hide resolved
src/Mvc/test/WebSites/BasicWebSite/Controllers/ContactApiController.cs
Outdated
Show resolved
Hide resolved
src/Mvc/Mvc.Core/src/ApplicationModels/ApiBehaviorApplicationModelProvider.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39667