Generate PlatformManifest and package conflict overrides for Microsoft.AspNetCore.App #4072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsplaisted
approved these changes
Nov 16, 2018
muratg
approved these changes
Nov 16, 2018
…t.AspNetCore.App This generates additional metadata for the .NET Core SDK to resolve conflicts between Microsoft.AspNetCore.App and PackageReferences which contain the same assemblies.
natemcmaster
force-pushed
the
namc/overrides
branch
from
17f1a48 to
61b9c29
Compare
Eilon
reviewed
Nov 16, 2018
| @@ -1,7 +1,11 @@ | |||
| # Don't run CI for this config | |||
| trigger: none | |||
There was a problem hiding this comment.
This disables the PR validation trigger when we push to branches. PR validation only needs to run on PRs.
Eilon
reviewed
Nov 16, 2018
| { | ||
| var platformManifestPath = Path.Combine(TestData.GetManifestOutputDir(), "Microsoft.AspNetCore.App.PlatformManifest.txt"); | ||
| var expectedAssemblies = TestData.GetSharedFxDependencies() | ||
| .Split(';', StringSplitOptions.RemoveEmptyEntries) |
There was a problem hiding this comment.
Is RemoveEmptyEntries really needed? Or would it just mask potential bugs where we put blank entries in the metadata?
There was a problem hiding this comment.
Not in this case. I'm only using remove empty entries on TestData.GetSharedFxDependencies(), which is test data generated in the unit test csproj file. The data isn't used in the product.
Eilon
reviewed
Nov 16, 2018
Eilon
approved these changes
Nov 16, 2018
added 2 commits
November 16, 2018 15:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generates additional metadata for the .NET Core SDK to resolve conflicts between Microsoft.AspNetCore.App and PackageReferences which contain the same assemblies.
Resolves #3609
Examples of the build output created:
Microsoft.AspNetCore.App.props
Microsoft.AspNetCore.App.PlatformManifest.txt