-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add MapGroup #41265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MapGroup #41265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see one test with MVC/SignalR/Health checks, something that's not the ModelDataSource.
Oh ALSO, I'd like a test that fires the change token for a data source that fires change tokens and it working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comment cleanup nits
Co-authored-by: Kahbazi <[email protected]> Co-authored-by: Brennan <[email protected]>
Do you have a test where we call MapGroup multiple times with the same prefix? I know we're not keeping track of the prefix but it shouldn't matter unless you have duplicate routes right? |
/backport to release/7.0-preview4 |
Started backporting to release/7.0-preview4: https://github.com/dotnet/aspnetcore/actions/runs/2222446298 |
This PR add a new MapGroup() extension method to
IEndpointRouteBuilder
. This returns a new builder for defining groups of endpoints with a common prefix that implements both theIEndpointRouteBuilder
andIEndpointConventionBuilder
interfaces. This can be used to add endpoints with the given group prefix, and to customize those endpoints using conventions.Sample Usage
Fixes #36007