Enable trimming for middleware and friends #41373
Conversation
ghost
added
the
community-contribution
| @@ -132,8 +134,6 @@ private async Task InvokeCore(HttpContext context) | |||
| return null; | |||
| } | |||
|
|
|||
| var contextType = Type.GetType(contextTypeName)!; | |||
There was a problem hiding this comment.
Maybe not? The current code expects contextTypeName to match an exact FQN but doesn't use the resulting match: https://github.com/dotnet/aspnetcore/blob/main/src/Middleware/Diagnostics.EntityFrameworkCore/src/MigrationsEndPointMiddleware.cs#L121-L135.
| @@ -9,6 +10,8 @@ namespace Microsoft.AspNetCore.Session; | |||
|
|
|||
| internal static class CookieProtection | |||
| { | |||
| [RequiresUnreferencedCode("This API uses Data Protection which may attempt to load types in a way that cannot be statically analyzed. " + | |||
There was a problem hiding this comment.
@blowdart This is problematic and we don't have a trimmable approach for doing something like data protection as yet. Something to think about in the future.
| @@ -76,6 +77,8 @@ public class SessionMiddleware | |||
| /// </summary> | |||
| /// <param name="context">The <see cref="HttpContext"/>.</param> | |||
| /// <returns>A <see cref="Task"/> that completes when the middleware has completed processing.</returns> | |||
| [RequiresUnreferencedCode("This API uses Data Protection which may attempt to load types in a way that cannot be statically analyzed. " + | |||
| @@ -119,3 +119,117 @@ public UnconditionalSuppressMessageAttribute(string category, string checkId) | |||
| /// </summary> | |||
| public string? Justification { get; set; } | |||
| } | |||
|
|
|||
| [AttributeUsage( | |||
There was a problem hiding this comment.
What's this for? NS2.0 projects?
There was a problem hiding this comment.
Yup. Healthchecks cross-compiles and needs it. The current approach is to include an internal attribute rather than ifdef the attribute usage.
pranavkm
force-pushed
the
middleware-trimming
branch
from
f97cd2f to
b0ddd60
Compare
pranavkm
force-pushed
the
middleware-trimming
branch
3 times, most recently
from
0b57518 to
a620b06
Compare
pranavkm
requested review from
Tratcher,
BrennanConroy,
a team,
dougbu,
wtgodbe and
Pilchie
as code owners
|
Let's play around with DataProtection trimming annotations before propagating its warning out to APIs that depend on it - #41411 |
pranavkm
force-pushed
the
middleware-trimming
branch
from
a620b06 to
d6e57b0
Compare
|
Took out Antiforgery and Session from the list as they were the only two affected by DataProtection. I'll have a another look at DataProtection, see what might work there. |
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <!-- Packages required to produce a complete dependency graph for the trimmer --> | |||
| <Reference Include="System.Configuration.ConfigurationManager" /> | |||
There was a problem hiding this comment.
Why does unchanged code need a new dependency e.g., is this related to the src/Shared/TrimmingAttributes.cs changes❔
There was a problem hiding this comment.
This project references everything in TrimmableProjects.props
A newly added trimmable project requires it.
amcasey
added
area-middleware
No description provided.