RequestDelegateFactory context classes ApplicationServices property #41952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `public IServiceProvider? Services { get; }` property to `RouteHandlerContext`
- Enables route handler filter factories to access app services
- Added a unit test & updated another to ensure app's service provider is passed through correctly by `RequestDelegateFactory`
Fixes #41900
DamianEdwards
requested review from
javiercn,
Tratcher,
BrennanConroy and
halter73
as code owners
ghost
added
the
davidfowl
reviewed
Jun 1, 2022
DamianEdwards
changed the title
DamianEdwards
changed the title
halter73
reviewed
Jun 3, 2022
halter73
approved these changes
Jun 3, 2022
src/Http/Routing/test/UnitTests/Builder/RouteHandlerEndpointRouteBuilderExtensionsTest.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Jun 3, 2022
DamianEdwards
added
the
* NO MERGE *
captainsafia
approved these changes
Jun 6, 2022
DamianEdwards
removed
the
* NO MERGE *
DamianEdwards
deleted the
damianedwards/41900-routehandlercontext-services
branch
captainsafia
pushed a commit
to captainsafia/aspnetcore
that referenced
this pull request
Jun 13, 2022
…otnet#41952) - Added `public IServiceProvider ApplicationServices { get; }` property to `RouteHandlerContext` - Enables route handler filter factories to access app services - Renamed existing `Services` property on `EndpointParameterMetadataContext` and `EndpointMetadataContext` to `ApplicationServices` and made it non-nullable - Added a unit test & updated another to ensure app's service provider is passed through correctly by `RequestDelegateFactory` Fixes dotnet#41900
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
public IServiceProvider? Services { get; }property toRouteHandlerContextRequestDelegateFactoryEndpointMetadataContext.ServicesandEndpointParameterMetadataContext.ServicestoApplicationServicesand made non-nullableApplicationServicesproperty is set correctlyFixes #41900