Skip to content

Split Blazor templates into 2 projects #42382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

BrennanConroy
Copy link
Member

Templates.Blazor.Tests were taking 30+ minutes and sometimes crossing the 40 minute test timeout boundary. Splitting the test into two projects; WebAssembly and Server to reduce the time each test leg takes to avoid hitting the 40 minutes.

Copy link
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mkArtakMSFT mkArtakMSFT added the area-blazor Includes: Blazor, Razor Components label Jun 23, 2022
@BrennanConroy BrennanConroy enabled auto-merge (squash) June 23, 2022 22:47
@BrennanConroy BrennanConroy disabled auto-merge June 23, 2022 22:47
@TanayParikh TanayParikh requested a review from a team June 23, 2022 22:55
@BrennanConroy
Copy link
Member Author

Verified # of tests between this and a previous build on main are roughly equal.

@BrennanConroy BrennanConroy merged commit f781efb into main Jun 23, 2022
@BrennanConroy BrennanConroy deleted the brecon/templateSplit branch June 23, 2022 23:16
@ghost ghost added this to the 7.0-preview7 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants