Reduce console spew when creating secrets in user-jwts#42542
Merged
Conversation
ghost
added
the
area-commandlinetools
| { | ||
| var resolver = new ProjectIdResolver(reporter, projectFilePath); | ||
| var resolver = new ProjectIdResolver(NullReporter.Singleton, projectFilePath); | ||
| var id = resolver.Resolve(projectFilePath, configuration: null); |
Member
There was a problem hiding this comment.
Why not pass in a higher configuration level by default and then we can have an option like user-secrets to have a different config level to get verbose logs:
https://source.dot.net/#dotnet-user-secrets/CommandLineOptions.cs,39
Contributor
Author
There was a problem hiding this comment.
We don't currently have a verbose flag on the tool, but even if we did I think we'd end up passing either a ConsoleReporter or NullReporter here depending on whether or not that verbose flag is set.
Member
|
spew 😄 |
BrennanConroy
approved these changes
Jul 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42474.