2.1: Merge Localization, BasicMiddleware, and Identity #4345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts our previous policy of cascading versions on all servicing updates. This moves variables into the 'pinned' section, and points them to the latest stable release (versions that were used at the time of the 2.1.2 release).
This reverts our previous policy of cascading versions on all servicing updates. This moves variables into the 'pinned' section, and points them to the latest stable release (versions that were used at the time of the 2.1.2 release).
This reverts our previous policy of cascading versions on all servicing updates. This moves variables into the 'pinned' section, and points them to the latest stable release (versions that were used at the time of the 2.1.2 release).
Per discussion with our team, we want to make the following changes to versioning during servicing updates: * The versioning on packages with ship with ASP.NET Core should be consistent * (No change) on packages with changes in them ship during servicing updates * Version gaps are okay. For example, this repo is producing a patch for 2.1.6, so packages will be 2.1.6. It did not patch for 2.1.4 or 2.1.3 so those versions will be skipped. This also includes another minor change: for consistency with the rest of the .NET Core teams, pre-release servicing builds will be 2.1.x-servicing-buildnumber.
Fix login.cshtml
…tion.Tests.csproj This isn't really a test project. It's a class library which contains testing compontents. Because 'xunit' is referenced, IsTestProject=true, which messes up some of the build logic we have for handling code signing and test runners
As a part of preparing this repo for merging into aspnet/AspNetCore, this code is being removed as it is currently not in a "shipping" state for 2.1.
Prior to reorganization, this source code was found in https://github.com/aspnet/BasicMiddleware/tree/1de636cd18309070792b68888ca29c8b85fac98b
Prior to reorganization, this source code was found in https://github.com/aspnet/Localization/tree/0bcac31dd705fb9db60723f5d7eaeffb728358f5
natemcmaster
changed the title
natemcmaster
force-pushed
the
merge-repos
branch
from
fb17758 to
d082f74
Compare
HaoK
approved these changes
Dec 1, 2018
added 2 commits
December 3, 2018 15:52
Prior to reorganization, this source code was found in https://github.com/aspnet/Identity/tree/fa3cfd08eb6af819adc5fef2d9b603638c4b4b3b
natemcmaster
force-pushed
the
merge-repos
branch
from
12696d0 to
a6b5bb1
Compare
|
🆙 📅 - this now includes all of Identity. The original plan was to move Microsoft.Extensions.Identity.* packages into aspnet/Extensions, but these projects appear to be so closely coupled to Microsoft.AspNetCore.Identity.* that we'd rather keep the source here in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of #3598, this replaces the git submodule for Localization and BasicMiddleware with local code.