Change WebSocket project to target netcoreapp3.0 #4346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougbu
approved these changes
Dec 1, 2018
|
Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore should be updated to netcoreapp3.0 since it will need to compile with FrameworkReference before we ship RTM (#4257) |
Tratcher
force-pushed
the
tratcher/3/middleware
branch
from
57ff816 to
07a355a
Compare
|
Updated. |
natemcmaster
approved these changes
Dec 1, 2018
dougbu
approved these changes
Dec 1, 2018
|
Need? No, but it's a good reminder that it's using a completely different stack for interop testing. |
Tratcher
force-pushed
the
tratcher/3/middleware
branch
from
07a355a to
c0381de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3754
This only changes the WebSocket package. The tests and samples were already updated.
These aren't getting updated, correct?
Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore
Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore
Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.Tests