-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/7.0] Update Roslyn Versions #44148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dougbu do we need to do manual validation for this (beyond automated CI) given this goes through tactics? If so, how would that be done? |
No idea. We've made changes like this in the past and you could check |
CI validation seems reasonable. |
Hi @TanayParikh. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
What's happening here❔ |
Hi @TanayParikh. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Was just updating the description, so removed the label temporarily. |
We do not expect this to have any tooling related impact. |
Update Roslyn Versions
Summary of the changes
Update the Roslyn version referenced by Razor to
4.4.0-3.22472.13
.Description
This is a routine change we complete every release to update the Roslyn version used by the Razor Runtime Compilation NuGet package. This PR uses the Roslyn version provided by @jaredpar.
The Razor Runtime Compilation NuGet package needs to reference a version of Roslyn that ships as a NuGet package. However, as Roslyn doesn't follow the runtime ship schedule, ASP.NET Core manually updates this package version.
Fixes: #39387
Customer Impact
This change ensures the version of Roslyn used by the Razor Runtime Compilation NuGet package is synchronized with the version of Roslyn used by the Razor Compiler (which ships as part of the SDK). Without synchronized Roslyn versions, we could have undefined behavior in our published packages.
Regression?
Risk
Routine version bump.
Verification
Due to the nature of this update, CI validation is sufficient.
Packaging changes reviewed?
References: