Skip to content

[release/7.0] Update Roslyn Versions #44148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

TanayParikh
Copy link
Contributor

@TanayParikh TanayParikh commented Sep 23, 2022

Update Roslyn Versions

Summary of the changes

Update the Roslyn version referenced by Razor to 4.4.0-3.22472.13.

Description

This is a routine change we complete every release to update the Roslyn version used by the Razor Runtime Compilation NuGet package. This PR uses the Roslyn version provided by @jaredpar.

The Razor Runtime Compilation NuGet package needs to reference a version of Roslyn that ships as a NuGet package. However, as Roslyn doesn't follow the runtime ship schedule, ASP.NET Core manually updates this package version.

Fixes: #39387

Customer Impact

This change ensures the version of Roslyn used by the Razor Runtime Compilation NuGet package is synchronized with the version of Roslyn used by the Razor Compiler (which ships as part of the SDK). Without synchronized Roslyn versions, we could have undefined behavior in our published packages.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Routine version bump.

Verification

  • Manual (required)
  • Automated

Due to the nature of this update, CI validation is sufficient.

Packaging changes reviewed?

  • Yes
  • No
  • N/A

References:

Using the roslyn versions provided by @jaredpar: #44072 (comment)

For: #39387

References:
- #28125
- #37764
- #44072
@TanayParikh TanayParikh requested review from a team, dougbu and wtgodbe as code owners September 23, 2022 17:11
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Sep 23, 2022
@TanayParikh
Copy link
Contributor Author

TanayParikh commented Sep 23, 2022

@dougbu do we need to do manual validation for this (beyond automated CI) given this goes through tactics? If so, how would that be done?

@dougbu
Copy link
Contributor

dougbu commented Sep 23, 2022

@dougbu do we need to do manual validation for this (beyond automated CI) given this goes through tactics? If so, how would that be done?

No idea. We've made changes like this in the past and you could check git blame for them to find who did them. But I bet the answer is we relied on the CI.

@TanayParikh
Copy link
Contributor Author

@jaredpar @mmitche @JamesNK in case you have any suggestions here

@mmitche
Copy link
Member

mmitche commented Sep 26, 2022

CI validation seems reasonable.

@TanayParikh TanayParikh added the Servicing-consider Shiproom approval is required for the issue label Sep 26, 2022
@ghost
Copy link

ghost commented Sep 26, 2022

Hi @TanayParikh. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@TanayParikh TanayParikh self-assigned this Sep 26, 2022
@TanayParikh TanayParikh removed the Servicing-consider Shiproom approval is required for the issue label Sep 26, 2022
@dougbu
Copy link
Contributor

dougbu commented Sep 26, 2022

@TanayParikh removed the Servicing-consider label

What's happening here❔

@TanayParikh TanayParikh added the Servicing-consider Shiproom approval is required for the issue label Sep 26, 2022
@ghost
Copy link

ghost commented Sep 26, 2022

Hi @TanayParikh. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@TanayParikh
Copy link
Contributor Author

@TanayParikh removed the Servicing-consider label

What's happening here❔

Was just updating the description, so removed the label temporarily.

@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Sep 27, 2022
@mkArtakMSFT mkArtakMSFT merged commit ed649ac into release/7.0 Sep 29, 2022
@mkArtakMSFT mkArtakMSFT deleted the TanayParikh-patch-3 branch September 29, 2022 19:01
@TanayParikh
Copy link
Contributor Author

We do not expect this to have any tooling related impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants