Skip to content

ApiAuthorizationDbContext.cs missing ServerSideSessions Patch #45145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

hi-diego
Copy link

@hi-diego hi-diego commented Nov 17, 2022

Missing ServerSideSessions property added to ApiAuthorizationDbContext.cs

Description

reflection is throwing this error

"Method 'get_ServerSideSessions' in type 'Microsoft.AspNetCore.ApiAuthorization.IdentityServer.ApiAuthorizationDbContext`1' from assembly 'Microsoft.AspNetCore.ApiAuthorization.IdentityServer, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' does not have an implementation."

IPersistedGrantDbContext.ServerSideSessions property must be implemented in the API ApiAuthorizationDbContext, this is required by IPersistedGrantDbContext Interface.

Fixes #44990

Add required IPersistedGrantDbContext.ServerSideSessions property
@ghost ghost added area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member labels Nov 17, 2022
@ghost
Copy link

ghost commented Nov 17, 2022

Thanks for your PR, @hi-diego. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@yakeer
Copy link

yakeer commented Dec 8, 2022

What's up with this PR?
It's quite critical for updating to .NET 7.

Copy link

@yakeer yakeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be added ASAP.

@ghost
Copy link

ghost commented Jan 25, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please remove the pending ci rerun label to kick off a new CI run.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 25, 2023
@HaoK HaoK removed their assignment Mar 1, 2023
@mkArtakMSFT
Copy link
Member

@halter73 can you please review this? Thanks!

@halter73
Copy link
Member

halter73 commented Mar 31, 2023

Thank you for your contribution, and sorry for the slow feedback. Microsoft.AspNetCore.ApiAuthorization.IdentityServer will no longer be supported going forward, so I'm closing this PR. We plan to stop shipping it in .NET 8, and we are going to be removing Duende's IdentityServer from our SPA templates. See #42158 (comment) @JeremyLikness

If you want to continue using IdentityServer, I recommend following the guidance laid out Duende's docs, templates and samples none of which use Microsoft.AspNetCore.ApiAuthorization.IdentityServer.

@halter73 halter73 closed this Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-identity Includes: Identity and providers community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
7 participants