-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Enable UsePkce
by default for Google and Facebook auth
#45235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your PR, @FranklinWhale. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
@Tratcher Unfortunately, with the new |
Changing a public/protected API signature is not allowed under our breaking changes guidelines. Try the other approach. |
Added comment and fixed the test. |
Thanks |
Enable
UsePkce
by default for Google and Facebook authSummary of the changes (Less than 80 chars)
Description
UsePkce
totrue
inGoogleOptions
andFacebookOptions
BuildChallengeUrl
inGoogleHandler
now callsbase.BuildChallengeUrl
AddQueryString
toSetQueryParam
inGoogleHandler
ChallengeWillTriggerRedirection
inGoogleTests
to check query dictionary instead of string matchingContributes to #4684