Skip to content

Convert Session to use Reference and move to Middleware folder #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2018

Conversation

JunTaoLuo
Copy link
Contributor

Part of #4246.

Marking as WIP since there are build issues.

@natemcmaster natemcmaster changed the base branch from master to release/2.1 December 11, 2018 22:14
@JunTaoLuo JunTaoLuo force-pushed the johluo/convert-session branch from 1641877 to 1042b27 Compare December 11, 2018 22:37
@JunTaoLuo JunTaoLuo changed the title WIP Convert Session to use Reference and move to Middleware folder Convert Session to use Reference and move to Middleware folder Dec 11, 2018
Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@JunTaoLuo JunTaoLuo merged commit 3acdfb3 into release/2.1 Dec 11, 2018
@JunTaoLuo JunTaoLuo deleted the johluo/convert-session branch December 11, 2018 22:56
JunTaoLuo pushed a commit that referenced this pull request Dec 12, 2018
* Workaround problems when opening solution files in Visual Studio (#4569)

Changes:

* Condense Routing.sln into HttpAbstractions.sln
* Workaround NU1105 by adding all ProjectReferences to the .sln
* Workaround exceptions in the ReferencesHostBridge by moving Reference items to a temporary item group
* Add a 'startvs.cmd' script for launching VS with the right env variables
* Remove RangeHelper test project
* Move RangeHelper tests into StaticFiles.Tests and add target for NPM restore

* Convert Session to use Reference and move to Middleware folder (#4576)

* Add RoutingSample.Web to HttpAbstractions.sln
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants