Skip to content

Update to scaffolding submodules for dotnet tool resolution workaround #4580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

seancpeters
Copy link
Contributor

Summary of the changes (Less than 80 chars)

  • Update the scaffolding submodule

Addresses dotnet/sdk#2698

@seancpeters
Copy link
Contributor Author

@natemcmaster @wli3 @vijayrkn

@natemcmaster natemcmaster added the Servicing-approved Shiproom has approved the issue label Dec 11, 2018
@natemcmaster natemcmaster added this to the 2.2.1 milestone Dec 11, 2018
@natemcmaster
Copy link
Contributor

Once PR checks pass, feel free to merge.

FYI @muratg @mmitche @Eilon - this should resolve the last 2.2.1 bug we're expecting to take. Once it, we're ready to re-build 2.2.1

@seancpeters
Copy link
Contributor Author

We got some test failures in the ci build, but they don't look related to scaffolding. I don't know much about this repo, perhaps someone who knows it better has a better understanding of what may have caused these errors.

Also, I don't have rights to merge in this repo, so once we're good, someone else will have to.

@natemcmaster
Copy link
Contributor

Test failures in HttpSys and Kestrel are known, right @Tratcher @muratg ?

Merging so we can get a 2.2.1 build going.

@natemcmaster natemcmaster merged commit 21488b2 into dotnet:release/2.2 Dec 11, 2018
@muratg
Copy link
Contributor

muratg commented Dec 11, 2018

Yeah, I think there are issues tracking the failures. Thanks for unblocking the 2.2.1 build!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants