Skip to content

Change build components to C++ Win10 17134 SDK #4603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

jkotalik
Copy link
Contributor

Part of https://github.com/aspnet/AspNetCore-Internal/issues/1505. 15063 doesn't exist on VS16.0 (VS2019).

This will conflict with #4311; I'm opening this to find any build issues primarily.

Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Wait until TeamCity is up to date, of course, then :shipit:

@jkotalik
Copy link
Contributor Author

I'm shocked our AzureDevOps agents have the component too 😄

@natemcmaster
Copy link
Contributor

It looks like the dnceng build queues don't have this yet. https://github.com/dotnet/core-eng/issues/4764. We haven't started using those queues yet, so it's okay to merge this.

@jkotalik
Copy link
Contributor Author

Going to put out other IIS test fires before starting a new one by merging this.

@jkotalik jkotalik force-pushed the jkotalik/installVSScript branch from 3caa2d8 to 3947104 Compare December 21, 2018 07:28
@jkotalik jkotalik merged commit 80bb14c into release/2.1 Dec 21, 2018
@jkotalik jkotalik deleted the jkotalik/installVSScript branch December 21, 2018 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants