Skip to content

Fix CORS Functional Tests #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Conversation

mikaelm12
Copy link
Contributor

Issue: https://github.com/aspnet/AspNetCore-Internal/issues/1394

This test depended on the existence of the CORS.sln file that went away when we moved to the Mondo Repo. This fixes the test that fails consistently.

@mikaelm12 mikaelm12 changed the title Mikaelm12/dont search for cor ssln Fix CORS Functional Tests Dec 12, 2018
Copy link
Member

@JamesNK JamesNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it 😋

@JunTaoLuo
Copy link
Contributor

Any idea what's up with the package-lock.json in the functional test project? When I run tests, that file updates and there's a massive diff. Is it even required to be source controlled?

@mikaelm12
Copy link
Contributor Author

You beat me to it 😋

😄

@mikaelm12
Copy link
Contributor Author

Any idea what's up with the package-lock.json in the functional test project? When I run tests, that file updates and there's a massive diff. Is it even required to be source controlled?

Not quite sure. Any ideas @BrennanConroy ?

@rynowak
Copy link
Member

rynowak commented Dec 12, 2018

package-lock.json is supposed to be source controller, but node does a poor job avoiding churn. Differences in platforms, line ending settings and node version all can cause this to change in a noisy way. This has been a real source of pain in Blazor for me and I never found a real solution.

@mikaelm12 mikaelm12 merged commit 9e76bec into release/2.2 Dec 12, 2018
@JunTaoLuo JunTaoLuo deleted the mikaelm12/DontSearchForCORSsln branch December 13, 2018 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants