Skip to content

Removing custom ProblemDetails Converters #46492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2023
Merged

Removing custom ProblemDetails Converters #46492

merged 2 commits into from
Feb 15, 2023

Conversation

brunolins16
Copy link
Member

Fix #44132

@brunolins16 brunolins16 marked this pull request as ready for review February 7, 2023 05:42
@ghost
Copy link

ghost commented Feb 14, 2023

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please remove the pending ci rerun label to kick off a new CI run.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 14, 2023
@brunolins16 brunolins16 added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels and removed pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun labels Feb 14, 2023
@ghost
Copy link

ghost commented Feb 14, 2023

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 46492 in repo dotnet/aspnetcore

@brunolins16
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@brunolins16
Copy link
Member Author

@dotnet/minimal-apis could you please review? 🙏

captainsafia
captainsafia approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that we use different serializer options across different test cases. Should we standardize on the web defaults for everything?

@brunolins16 brunolins16 enabled auto-merge (squash) February 15, 2023 18:06
@brunolins16 brunolins16 merged commit 330d246 into dotnet:main Feb 15, 2023
@ghost ghost added this to the 8.0-preview2 milestone Feb 15, 2023
@brunolins16 brunolins16 deleted the brunolins16/public-apis/44132 branch February 15, 2023 21:21
@js8080 js8080 mentioned this pull request Jan 26, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@captainsafia captainsafia captainsafia approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees
No one assigned
Labels
old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels
Projects
None yet
Milestone
8.0-preview2
Development

Successfully merging this pull request may close these issues.

Remove (Http)(Validation)ProblemDetails converters
3 participants
@brunolins16 @halter73 @captainsafia