StatusCodePagesMiddleware: Improving response started verification #46576
Conversation
ghost
added
the
brunolins16
added
old-area-web-frameworks-do-not-use
| @@ -26,21 +26,26 @@ public StatusCodePagesOptions() | |||
|
|
|||
| if (context.HttpContext.RequestServices.GetService<IProblemDetailsService>() is { } problemDetailsService) | |||
| { | |||
| await problemDetailsService.WriteAsync(new () | |||
| await problemDetailsService.WriteAsync(new() | |||
| { | |||
| HttpContext = context.HttpContext, | |||
| ProblemDetails = { Status = statusCode } | |||
| }); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Checking the content-length and content-type is weird, just make the original code an else block.
| else | |
| { | |
| context.HttpContext.Response.ContentType = "text/plain"; | |
| await context.HttpContext.Response.WriteAsync(body); | |
| } |
There was a problem hiding this comment.
Oh, just saw your comment on the issue... I'll revisit this next week, but I still don't think we want to rely on checking content-length or content-type to determine the presence of a buffered body.
There was a problem hiding this comment.
Yeah! I don't like it as well but since we were using it already, I decided to suggest it. I tried a repro to see if I can find something reliable but as I mentioned, in the issue, I was not able to repro.
|
Closing this PR to work on a more appropriated fix. |
|
Hi @brunolins16. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Fix #45678