Introducing IProblemDetailsService.TryWriteAsync
#46680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunolins16
requested review from
a team,
Tratcher,
BrennanConroy and
halter73
as code owners
Tratcher
approved these changes
Feb 17, 2023
| { | ||
| return ValueTask.CompletedTask; | ||
| throw new InvalidOperationException("Unable to find a registered `IProblemDetailsWriter` that can write to the given context."); |
There was a problem hiding this comment.
Throwing is a breaking behavior change?
There was a problem hiding this comment.
It is but I believe it is consistent with TryParse/Parse approach. However, I ok to not do that and avoid this breaking change
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45678
This PR introduces a new public api (#45678 (comment)) and also drop the restriction to create
Problem Detailsonly when the status code is>= 400