Skip to content

[release/8.0-preview3] Follow up 'Ability to monitor Blazor Server circuit activity' #47354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Mar 21, 2023

Follow up 'Ability to monitor Blazor Server circuit activity'

Updates the API for the "Ability to monitor circuit activity" feature according to feedback from the API proposal issue: #47325

Description

The initial API for this feature is already in the release/8.0-preview3 branch. After the feature went through API review, there was a follow-up PR that didn't pass CI before the branch snap. This PR backports the API update to avoid introducing a breaking change between the Preview 3 and Preview 4 releases.

Fixes #47325

Customer Impact

Without this fix, customers utilizing this new feature in Preview 3 will be broken by the changes to its API in Preview 4. This fix prevents such a break from happening.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

This change only modifies a new feature being added in Preview 3. Existing functionality is unlikely to be impacted.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@MackinnonBuck MackinnonBuck added area-blazor Includes: Blazor, Razor Components ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels Mar 21, 2023
@MackinnonBuck MackinnonBuck requested a review from a team as a code owner March 21, 2023 17:05
@mkArtakMSFT mkArtakMSFT added Servicing-consider Shiproom approval is required for the issue and removed ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. labels Mar 21, 2023
@ghost
Copy link

ghost commented Mar 21, 2023

Hi @MackinnonBuck. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Mar 23, 2023
@ghost
Copy link

ghost commented Mar 23, 2023

Hi @MackinnonBuck. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@mkArtakMSFT
Copy link
Contributor

This is now approved and ready to merge!

@wtgodbe wtgodbe merged commit 85d5d6b into release/8.0-preview3 Mar 23, 2023
@wtgodbe wtgodbe deleted the mbuck/backport-monitor-circuit-activity branch March 23, 2023 16:14
@ghost ghost added this to the 8.0-preview3 milestone Mar 23, 2023
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants