-
Notifications
You must be signed in to change notification settings - Fork 10.3k
http.sys (7.0 backport): new option for response buffering #48073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mgravell. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the minor comment.
Co-authored-by: Aditya Mandaleeka <[email protected]>
@wtgodbe for servicing when possible |
Tactics mail sent, awaiting approval. |
Approved. |
Hi @mgravell. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
HttpSys: new option for response buffering
8.0 feature: #47776
(same functionally as #48072)
Description
As per old PR 418 (direct copy), enables kernel mode response-buffering in http.sys - with modification to use app-context switch rather than public API change
Customer Impact
Without this buffer, writes are sent as-written direct thru http.sys; this has two problems:
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
When servicing release/2.1