Skip to content

RDF test migration for some response test cases. #48611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 9, 2023
Merged

RDF test migration for some response test cases. #48611

merged 8 commits into from
Jun 9, 2023

Conversation

mitchdenny
Copy link
Member

Partially addresses #47345

@ghost ghost added the area-runtime label Jun 5, 2023
@mitchdenny mitchdenny requested a review from BrennanConroy June 6, 2023 02:47
captainsafia
captainsafia reviewed Jun 6, 2023
View reviewed changes
...legateGenerator/Baselines/MapAction_ExplicitServiceParam_SimpleReturn_Snapshot.generated.txt
var result = handler(svc_local);
if (result is string)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, feels like we can do this in the same place where we write the response (as in the ExecuteReturnAsync handlers referenced above) instead of duplicating the check for hte result.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be misunderstanding. If we don't have any filters we don't use ExecuteObjectResult unless I'm misreading the code.

@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 6, 2023
@mitchdenny mitchdenny merged commit 68545a0 into dotnet:main Jun 9, 2023
@ghost ghost added this to the 8.0-preview6 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainsafia captainsafia captainsafia approved these changes

@Tratcher Tratcher Awaiting requested review from Tratcher

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy is a code owner

Assignees
No one assigned
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc
Projects
None yet
Milestone
8.0-preview6
Development

Successfully merging this pull request may close these issues.
4 participants
@mitchdenny @captainsafia @BrennanConroy @amcasey