Skip to content

Add EditContext.IsValid(..) to determine if a field has any associated validation messages - #48698

Merged
mkArtakMSFT merged 4 commits into
dotnet:mainfrom
ElderJames:feat/editcontext-isvalid
Aug 14, 2023
Merged

mkArtakMSFT merged 4 commits into
dotnet:mainfrom
ElderJames:feat/editcontext-isvalid

Conversation

@ElderJames

Copy link
Copy Markdown
Contributor

Add EditContext.IsValid(..) to determine if a field has any associated validation messages

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

Implement the EditContext.IsValid(FieldIdentifier fieldIdentifier) API.

Fixes #31252

@ElderJames
ElderJames requested a review from a team as a code owner June 10, 2023 02:47
@ghost ghost added area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member labels Jun 10, 2023
@ghost

ghost commented Jun 10, 2023

Copy link
Copy Markdown

Thanks for your PR, @ElderJames. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@ghost

ghost commented Jun 17, 2023

Copy link
Copy Markdown

Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no breaking changes are introduced, please leave an /azp run comment here to rerun the CI pipeline and confirm success before merging the change.

@ghost ghost added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jun 17, 2023
@mkArtakMSFT

Copy link
Copy Markdown
Contributor

@SteveSandersonMS can you please review this? Thanks!

@mkArtakMSFT mkArtakMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @ElderJames.
The APIs you've added look good. Could you please also include tests for these new APIs in https://github.com/dotnet/aspnetcore/blob/main/src/Components/Forms/test/EditContextTest.cs?

@ElderJames

Copy link
Copy Markdown
Contributor Author

@mkArtakMSFT I have added the test for that, thank you!

@mkArtakMSFT
mkArtakMSFT merged commit 27089dd into dotnet:main Aug 14, 2023
@ghost ghost added this to the 8.0-rc1 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add EditContext.IsValid(..) to determine if a field has any associated validation messages.

3 participants