-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Blazor] Improvements to the interaction between SSR and interactive rendering #49238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
acaba4d
Stream updates can remove interactive components
MackinnonBuck 7666f56
Merge remote-tracking branch 'origin/main' into mbuck/ssr-boundary-im…
MackinnonBuck 5a7c33f
Improved DOM syncing
MackinnonBuck 674cf33
Working boundary syncing, WASM TODO
MackinnonBuck 95b262f
Minor cleanup
MackinnonBuck 2c0bfa8
WebAssembly support
MackinnonBuck 3145735
Update EndpointHtmlRenderer.Streaming.cs
MackinnonBuck 62d8dd4
Don't remove components from DOM
MackinnonBuck 531d296
Support for '@key', other improvements
MackinnonBuck 8319aca
Merge remote-tracking branch 'origin/main' into mbuck/ssr-boundary-im…
MackinnonBuck f9b688d
Small fixes
MackinnonBuck fea2dcb
Create blazor.webview.js
MackinnonBuck 4949da5
Cleanup
MackinnonBuck 18829c8
Undo small change
MackinnonBuck f8e38de
Small fixes
MackinnonBuck 95cce82
Update SSRRenderModeBoundary.cs
MackinnonBuck 7373384
Merge remote-tracking branch 'origin/main' into mbuck/ssr-boundary-im…
MackinnonBuck abe2fb4
Stability improvements
MackinnonBuck dadb3cc
More stability improvements
MackinnonBuck 8bb4182
Update InteractiveStreamingRenderingComponent.razor
MackinnonBuck d339790
Basic tests, lots more on the way
MackinnonBuck 582517e
Update TestCircuitHost.cs
MackinnonBuck b162b3b
More tests
MackinnonBuck b3a01fa
Improved marker key generation
MackinnonBuck 43bb43f
PR feedback
MackinnonBuck File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
src/Components/Server/src/Circuits/IServerComponentDeserializer.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,15 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Diagnostics.CodeAnalysis; | ||
|
||
namespace Microsoft.AspNetCore.Components.Server; | ||
|
||
internal interface IServerComponentDeserializer | ||
{ | ||
bool TryDeserializeComponentDescriptorCollection( | ||
string serializedComponentRecords, | ||
out List<ComponentDescriptor> descriptors); | ||
|
||
bool TryDeserializeSingleComponentDescriptor(ServerComponentMarker record, [NotNullWhen(true)] out ComponentDescriptor? result); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return
probably not needed, though unsure if you're adding this intentionally as a matter of code style ahead of local functions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was intentional to make it clear that there isn't some code hiding after the local function declarations. I can remove it if you feel that it adds more confusion than it eliminates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can consider not putting these local functions if their "combined size" is so big that makes you lose track of what's going on in the method. They might be better off as separate members.