Skip to content

Add health checks routing extensions #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Dec 15, 2018

TODO:

Fixes #4617

@JamesNK JamesNK requested a review from rynowak December 15, 2018 06:40
@JamesNK
Copy link
Member Author

JamesNK commented Dec 15, 2018

@rynowak UseHealthChecks supports limiting access to a port. What do you think of shipping the DomainMatcherPolicy that I wrote as a sample in routing? Then it would be a simple matter of setting the appropriate metadata for the healthchecks endpoint.

@rynowak
Copy link
Member

rynowak commented Dec 18, 2018

As discussed we want support for filtering on host/port, I'm ok with that to land separately.

Copy link
Member

@rynowak rynowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Need to get final polish

@JamesNK
Copy link
Member Author

JamesNK commented Dec 18, 2018

re: host/port

UseMiddleware has port as an argument. Do you have a strong preference on whether MapHealthChecks should have an overload that takes a port and adds the metadata for you, or do we tell people to use a standard extension method to add port metadata.

I lean towards and extension method but I don't have a strong preference either way.

@rynowak
Copy link
Member

rynowak commented Dec 19, 2018

I lean towards extension method as well if it's easy to use. If not we can add it back as first-class, so lets start with the extension method

@JamesNK JamesNK force-pushed the jamesnk/healthchecks-endpoints branch from cfa8b4b to fa5a0dd Compare December 19, 2018 02:12
@JamesNK JamesNK changed the title [WIP] Add health checks routing extensions Add health checks routing extensions Dec 19, 2018
@JamesNK
Copy link
Member Author

JamesNK commented Dec 19, 2018

🆙 📅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants