-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add health checks routing extensions #5127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rynowak UseHealthChecks supports limiting access to a port. What do you think of shipping the |
src/Middleware/HealthChecks/src/Builder/HealthCheckEndpointRouteBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/Middleware/HealthChecks/src/Builder/HealthCheckEndpointRouteBuilderExtensions.cs
Show resolved
Hide resolved
As discussed we want support for filtering on host/port, I'm ok with that to land separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good. Need to get final polish
re: host/port UseMiddleware has port as an argument. Do you have a strong preference on whether MapHealthChecks should have an overload that takes a port and adds the metadata for you, or do we tell people to use a standard extension method to add port metadata. I lean towards and extension method but I don't have a strong preference either way. |
I lean towards extension method as well if it's easy to use. If not we can add it back as first-class, so lets start with the extension method |
cfa8b4b
to
fa5a0dd
Compare
🆙 📅 |
TODO:
Support port?done later via a matcher policy Add host matcher policy to routing #5957Fixes #4617