-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[release/8.0] Fix radio button reset after submitting enhanced form #52219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Fix radio button reset after submitting enhanced form #52219
Conversation
* fix radio button reset when submitting enhanced form * rename test * new fix * Update src/Components/Web.JS/test/DomSync.test.ts Co-authored-by: Steve Sanderson <[email protected]> * Update src/Components/Web.JS/src/Rendering/DomMerging/DomSync.ts Co-authored-by: Steve Sanderson <[email protected]> --------- Co-authored-by: Steve Sanderson <[email protected]>
Hi @surayya-MS. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Hi @surayya-MS. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a backport. Otherwise, let me know.
Hi @surayya-MS. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
@surayya-MS can you please resolve these conflict, so that I can merge this tomorrow? Thanks! |
@surayya-MS :( |
[release 8.0] Fix radio button reset after submitting enhanced form
Manual backport of #51796
Description
This PR fixes resetting radio button checked property after submitting an enhanced form.
Workaround is to remove
data-enhance
attribute.Fixes #51429
Customer Impact
Without this change customers will have bad experience using enhanced form that contains radio button. Radio button won't get reset after submitting the form.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
This is a minor change. We have similar logic for checkbox approved #50991. There are unit and e2e tests for this change.
Verification
Packaging changes reviewed?
When servicing release/2.1
Fixes #51429