-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[Blazor] Centralize our JS build setup #53150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiercn
commented
Jan 4, 2024
- Adds a Shared.JS folder to contain all the build configs that are common/base/shared across all our component "JS" packages.
- Adds 'Shared.JS/rollup.config.mjs' to define a base config that packages can customize.
- Adds 'Shared.JS/tsconfig.json' base config that other packages can extend.
- Updates individual packages to generate the bundler config based on 'Shared.JS/rollup.config.mjs'
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
575139e
to
3c68915
Compare
dfb81eb
to
f36fe99
Compare
9913d5a
to
f9ae20a
Compare
b93144b
to
6e3a64f
Compare
Base automatically changed from
javiercn/move-to-rollup-other-blazor-js
to
main
January 5, 2024 11:35
6e3a64f
to
15c6a58
Compare
15c6a58
to
bee21d7
Compare
MackinnonBuck
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.